Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 46546fdf9e2060dac8d02fe2b479475b7985b830
https://github.com/WebKit/WebKit/commit/46546fdf9e2060dac8d02fe2b479475b7985b830
Author: Chris Dumez <[email protected]>
Date: 2026-06-05 (Fri, 05 Jun 2026)
Changed paths:
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
R Source/WebCore/platform/text/cocoa/CoreTextChineseCompositionEngine.cpp
R Source/WebCore/platform/text/cocoa/CoreTextChineseCompositionEngine.h
R Source/WebCore/platform/text/cocoa/CoreTextCompositionEngine.cpp
R Source/WebCore/platform/text/cocoa/CoreTextCompositionEngine.h
Log Message:
-----------
Remove unused CoreText composition engine SPI
https://bugs.webkit.org/show_bug.cgi?id=316379
Reviewed by Vitor Roriz.
CompositionRules::characterSpacing and ChineseCompositionRules were added in
252171@main as Private SPI, but no consumer materialized — neither inside
WebCore nor anywhere else in the tree calls into them. The implementation
also contains two bugs that have gone unnoticed precisely because the code
is dead:
- characterClass() reaches "if (character)
characterToCharacterClass(character);"
but discards the result, falling through to "return Other". Full-width and
half-width classification never happens.
- characterSpacing() computes afterClass from beforeCharacter (copy-paste),
so the spacing-table lookup uses the wrong column for any asymmetric pair.
Rather than fix dead code, delete it. If a future consumer needs this logic,
it can be reintroduced (correctly) at that time.
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/text/cocoa/CoreTextChineseCompositionEngine.cpp:
Removed.
* Source/WebCore/platform/text/cocoa/CoreTextChineseCompositionEngine.h:
Removed.
* Source/WebCore/platform/text/cocoa/CoreTextCompositionEngine.cpp: Removed.
* Source/WebCore/platform/text/cocoa/CoreTextCompositionEngine.h: Removed.
Canonical link: https://commits.webkit.org/314625@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
