Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 72d07dd3a9ddf086d361a7ca83e48d64676596cc
https://github.com/WebKit/WebKit/commit/72d07dd3a9ddf086d361a7ca83e48d64676596cc
Author: lilly <[email protected]>
Date: 2026-06-05 (Fri, 05 Jun 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/base.py
M Tools/Scripts/webkitpy/port/base_unittest.py
Log Message:
-----------
Variant WPT with a . in the params cause a failure
https://bugs.webkit.org/show_bug.cgi?id=316341
rdar://178763669
Reviewed by Sam Sneddon and Simon Fraser.
test_exists() used splitext() to strip the variant from a test name
before checking if the file exists, but splitext() splits on the last
dot in the string — so a variant containing a decimal value like 2.3
causes the split to land inside the variant instead of at the file
extension, making the style checker reject valid TestExpectations
entries. Fix by using test_name_and_variant() which correctly
partitions on the first ? or #, and add . to sanitized_variant()'s
regex so decimal dots don't appear in expected output filenames.
* Tools/Scripts/webkitpy/port/base.py:
(Port.test_exists):
* Tools/Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_test_exists):
Canonical link: https://commits.webkit.org/314642@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
