Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e1ec783ecdf5475104f18b4bb3e023395cfa77be
https://github.com/WebKit/WebKit/commit/e1ec783ecdf5475104f18b4bb3e023395cfa77be
Author: Geoffrey Garen <[email protected]>
Date: 2026-06-05 (Fri, 05 Jun 2026)
Changed paths:
M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp
M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h
Log Message:
-----------
[CMake] Build fix for builds with precompiled header codegen (fixing
314624@main)
https://bugs.webkit.org/show_bug.cgi?id=316435
rdar://178839407
Reviewed by Pascoe.
Forward-declare Connection and move ~NetworkNotificationManager() out of
line to work around the clang PCH vtable bug.
This does not re-introduce the xpc_object_t ODR issue because we are
decreasing our #include of WebPushDaemonConnection.h rather than
increasing.
* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp:
Move ~NetworkNotificationManager() out of line to force the key function
for this class to be in a .cpp file separate the from the precompiled header.
This works around the clang bug that causes the precompiled header to say "I
don't have to emit the vtable because someone else will" while all other
translation units say "I don't have to emit the vtable because the PCH will".
Canonical link: https://commits.webkit.org/314656@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
