Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1a27ef7f3b4246c19184a9d326932e973eabb18a
https://github.com/WebKit/WebKit/commit/1a27ef7f3b4246c19184a9d326932e973eabb18a
Author: Sihui Liu <[email protected]>
Date: 2026-06-05 (Fri, 05 Jun 2026)
Changed paths:
M Tools/CISupport/build-webkit-org/config.json
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py
M Tools/CISupport/ews-build/config.json
M Tools/Scripts/run-api-tests
M Tools/Scripts/webkitpy/api_tests/runner.py
M Tools/TestWebKitAPI/Runner/TestWebKitAPI.swift
M Tools/TestWebKitAPI/generic/main.mm
Log Message:
-----------
[Site Isolation] Bots no longer run API tests with Site Isolation after
switching to use --additional-header
https://bugs.webkit.org/show_bug.cgi?id=316358
rdar://178773623
Reviewed by Jonathan Bedard.
When CI bots were updated to use --additional-header=SiteIsolationEnabled=true
to enable Site Isolation for layout
tests, the corresponding --site-isolation flag was dropped from
additionalArguments (314188@main). This flag was the
only way to enable Site Isolation for run-api-tests, so API tests silently
stopped running under Site Isolation.
Fix this by renaming --site-isolation to --site-isolation-enabled-by-default in
run-api-tests and its test binaries
(TestWebKitAPI/generic/main.mm and TestWebKitAPI/Runner/TestWebKitAPI.swift),
matching the flag already used by
run-webkit-tests for the same purpose. Update CI bots to pass
--site-isolation-enabled-by-default, replacing the
now-redundant --additional-header=SiteIsolationEnabled=true and
--additional-expectations flags (run-webkit-tests
handles those automatically when --site-isolation-enabled-by-default is set).
* Tools/CISupport/build-webkit-org/config.json:
* Tools/CISupport/build-webkit-org/steps.py:
(RunWebKitTests.run):
(RunAPITests):
* Tools/CISupport/build-webkit-org/steps_unittest.py:
* Tools/Scripts/run-api-tests:
(main):
(run):
(parse_args):
* Tools/Scripts/webkitpy/api_tests/runner.py:
(Runner.command_for_port):
* Tools/TestWebKitAPI/Runner/TestWebKitAPI.swift:
(TestWebKitAPI.handleArguments(_:)):
* Tools/TestWebKitAPI/generic/main.mm:
Canonical link: https://commits.webkit.org/314667@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
