Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: beb1d4628418c5bc008f795e1ae5aed9680fd30f
https://github.com/WebKit/WebKit/commit/beb1d4628418c5bc008f795e1ae5aed9680fd30f
Author: Sam Sneddon <[email protected]>
Date: 2026-06-05 (Fri, 05 Jun 2026)
Changed paths:
M Tools/Scripts/webkitpy/w3c/test_exporter.py
M Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
Log Message:
-----------
[export-w3c-test-changes] Remove support for exporting Bugzilla attachments
https://bugs.webkit.org/show_bug.cgi?id=297919
rdar://159206512
Reviewed by Elliott Williams.
The Bugzilla attachment and bug-id paths are practically unused, and
make related improvements harder because they lack the full context of
a git commit. Remove them so that the exporter always derives the bug
from the git commit. Simplify the constructor by removing the
dependency-injection parameters that only existed to support the
removed paths.
Drive-by: remove the WPTLinterClass parameter from
WebPlatformTestExporter, the last dependency-injection paramter, since
the tests already patch the module-level name.
* Tools/Scripts/webkitpy/tool/steps/wptchangeexport.py:
(WPTChangeExport.run): Require git_commit instead of bug_id, and
build args without --bug.
* Tools/Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter.__init__): Remove bugzillaClass,
WPTLinterClass, and WKRepository parameters. Remove bug_id and
attachment_id handling; always derive the bug from the git commit.
(WebPlatformTestExporter._branch_name): Simplify now that bug_id is
always set.
(WebPlatformTestExporter._get_wpt_repository): Use WPTLinter directly
instead of indirecting through self._linter class reference.
(WebPlatformTestExporter.create_branch_with_patch):
(WebPlatformTestExporter.do_export):
(parse_args): Remove -b/--bug and -a/--attachment arguments. Update
usage description.
* Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py:
(TestExporterTest.setUp):
(TestExporterTest.test_export):
(TestExporterTest.test_export_with_specific_branch):
(TestExporterTest.test_export_no_clean):
(TestExporterTest.test_export_interactive_mode):
(TestExporterTest.test_export_invalid_token):
(TestExporterTest.test_export_wrong_token):
(TestExporterTest.test_has_wpt_changes):
(TestExporterTest.test_has_no_wpt_changes_for_no_diff):
(TestExporterTest.MockBugzilla): Removed.
(TestExporterTest.MockBugzilla.__init__): Deleted.
(TestExporterTest.MockBugzilla.fetch_bug_dictionary): Deleted.
(TestExporterTest.MockBugzilla.post_comment_to_bug): Deleted.
Canonical link: https://commits.webkit.org/314677@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
