Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 54090eb0904c1adfef296291012ad7800690cf2f
https://github.com/WebKit/WebKit/commit/54090eb0904c1adfef296291012ad7800690cf2f
Author: Ahmad Saleem <[email protected]>
Date: 2026-06-08 (Mon, 08 Jun 2026)
Changed paths:
M Source/WebCore/rendering/RenderFrameSet.cpp
M Source/WebCore/rendering/RenderFrameSet.h
Log Message:
-----------
Use default member initializers for RenderFrameSet data members
https://bugs.webkit.org/show_bug.cgi?id=316552
rdar://179024722
Reviewed by Simon Fraser.
RenderFrameSet and its nested GridAxis spread member initialization across
hand-written constructor init lists. GridAxis::GridAxis() only initialized
m_splitBeingResized and omitted m_splitResizeOffset, leaving it uninitialized;
it happens to be assigned in startResizing() before its read in
continueResizing(), so there is no observable change, but the member was not
safely default-initialized.
Move the data members to default member initializers in the header so every
constructor stays in sync:
- GridAxis::m_splitBeingResized defaults to noSplit and m_splitResizeOffset to
0, letting GridAxis() become = default.
- RenderFrameSet::m_isResizing defaults to false.
The GridAxis constructor definition and the RenderFrameSet m_isResizing init
list entry are dropped. No change in behavior.
* Source/WebCore/rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::RenderFrameSet):
(WebCore::RenderFrameSet::GridAxis::GridAxis): Deleted.
* Source/WebCore/rendering/RenderFrameSet.h:
Canonical link: https://commits.webkit.org/314766@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
