Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3432c645638dd236512e712205f0a755ee7b87d0
https://github.com/WebKit/WebKit/commit/3432c645638dd236512e712205f0a755ee7b87d0
Author: Tyler Wilcock <[email protected]>
Date: 2026-06-10 (Wed, 10 Jun 2026)
Changed paths:
A
LayoutTests/accessibility/mac/input-type-change-without-renderer-expected.txt
A LayoutTests/accessibility/mac/input-type-change-without-renderer.html
M Source/WebCore/accessibility/AXObjectCache.cpp
Log Message:
-----------
AX: AXObjectCache::handleAttributeChange never actually handles changes to
the type attribute due to ARIA early-return
https://bugs.webkit.org/show_bug.cgi?id=315580
rdar://177966699
Reviewed by Chris Fleizach.
For performance, before checking for any ARIA property,
AXObjectCache::handleAttributeChange checks
whether the attribute starts with `aria-` and returns early if it does not. Our
handling for the `type`
attribute was after this early return, and thus could not have ever been
reached.
Fix this and add a test
(accessibility/mac/input-type-change-without-renderer.html) that fails without
this fix.
*
LayoutTests/accessibility/mac/input-type-change-without-renderer-expected.txt:
Added.
* LayoutTests/accessibility/mac/input-type-change-without-renderer.html: Added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
Canonical link: https://commits.webkit.org/314900@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
