Title: [115094] trunk/Tools
- Revision
- 115094
- Author
- [email protected]
- Date
- 2012-04-24 12:28:07 -0700 (Tue, 24 Apr 2012)
Log Message
[TestResultsServer] Add a unit test for changes in r114868
https://bugs.webkit.org/show_bug.cgi?id=84713
Reviewed by Ojan Vafai.
Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
that is created for either DEPS or ToT builder groups. The unit test covers changes
made in r114868.
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
(testBuilderGroupIsToTWebKitAttribute.assertEquals):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (115093 => 115094)
--- trunk/Tools/ChangeLog 2012-04-24 19:19:35 UTC (rev 115093)
+++ trunk/Tools/ChangeLog 2012-04-24 19:28:07 UTC (rev 115094)
@@ -1,3 +1,18 @@
+2012-04-24 Zan Dobersek <[email protected]>
+
+ [TestResultsServer] Add a unit test for changes in r114868
+ https://bugs.webkit.org/show_bug.cgi?id=84713
+
+ Reviewed by Ojan Vafai.
+
+ Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
+ that is created for either DEPS or ToT builder groups. The unit test covers changes
+ made in r114868.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+ (testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
+ (testBuilderGroupIsToTWebKitAttribute.assertEquals):
+
2012-04-24 Brady Eidson <[email protected]>
<rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (115093 => 115094)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-04-24 19:19:35 UTC (rev 115093)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-04-24 19:28:07 UTC (rev 115094)
@@ -645,6 +645,26 @@
assertEquals(g_errorMessages, 'ERROR: Failed to get data from builder1,builder2.<br>ERROR: Data from staleBuilder1 is more than 1 day stale.<br>');
}
+function testBuilderGroupIsToTWebKitAttribute()
+{
+ var dummyMaster = new BuilderMaster('dummy.org', 'http://build.dummy.org');
+ var testBuilderGroups = {
+ '@ToT - dummy.org': null,
+ '@DEPS - dummy.org': null,
+ }
+ var testJSONData = "{ \"Dummy Builder 1\": null, \"Dummy Builder 2\": null }";
+
+ // Override g_handleBuildersListLoaded to avoid entering an infinite recursion
+ // as the builder lists are being loaded with dummy data.
+ g_handleBuildersListLoaded = function() { }
+
+ onBuilderListLoad(testBuilderGroups, function() { return true; }, dummyMaster, '@ToT - dummy.org', BuilderGroup.TOT_WEBKIT, JSON.parse(testJSONData));
+ assertEquals(testBuilderGroups['@ToT - dummy.org'].isToTWebKit, true);
+
+ onBuilderListLoad(testBuilderGroups, function() { return true; }, dummyMaster, '@DEPS - dummy.org', BuilderGroup.DEPS_WEBKIT, JSON.parse(testJSONData));
+ assertEquals(testBuilderGroups['@DEPS - dummy.org'].isToTWebKit, false);
+}
+
function htmlEscape(string)
{
var div = document.createElement('div');
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
