Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 02dbc28ba78a31f559899a2fbe7e74081153eadd
https://github.com/WebKit/WebKit/commit/02dbc28ba78a31f559899a2fbe7e74081153eadd
Author: Aakash Jain <[email protected]>
Date: 2026-06-15 (Mon, 15 Jun 2026)
Changed paths:
R Tools/CISupport/Shared/generate-s3-url
A Tools/CISupport/Shared/generate_s3_url.py
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[CISupport] Refactor GenerateS3URL build step to call generateS3URL directly
instead of via subprocess
https://bugs.webkit.org/show_bug.cgi?id=316674
rdar://179127972
Reviewed by Jonathan Bedard.
GenerateS3URL was implemented as a MasterShellCommand that spawned
python3 to invoke ../Shared/generate-s3-url, then re-parsed the
generated URL out of the subprocess's stdout via a regex log
observer. Both halves of that dance are unnecessary: the helper is
already a Python module living next to the buildbot master, and the
master process already has boto3 loaded. Rename generate-s3-url to
generate_s3_url.py so it can be imported, switch GenerateS3URL to
call generateS3URL() in-process, and update the unit tests
accordingly.
* Tools/CISupport/Shared/generate-s3-url: Renamed to generate_s3_url.py.
* Tools/CISupport/Shared/generate_s3_url.py:
* Tools/CISupport/build-webkit-org/steps.py:
* Tools/CISupport/build-webkit-org/steps_unittest.py:
* Tools/CISupport/ews-build/steps.py:
* Tools/CISupport/ews-build/steps_unittest.py:
Canonical link: https://commits.webkit.org/315213@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
