Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e78e1b72a759be2e387bf71c9652059c3d8d0363
https://github.com/WebKit/WebKit/commit/e78e1b72a759be2e387bf71c9652059c3d8d0363
Author: Elliott Williams <[email protected]>
Date: 2026-06-15 (Mon, 15 Jun 2026)
Changed paths:
A Tools/TestWebKitAPI/Helpers/cocoa/MediaRemoteSoftLink.h
A Tools/TestWebKitAPI/Helpers/cocoa/MediaRemoteSoftLink.mm
A Tools/TestWebKitAPI/Helpers/cocoa/ScreenTimeExtras.h
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/AdaptiveImageGlyph.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/Badging.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/MediaMutedState.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/MediaSession.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/NowPlaying.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ScreenTime.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/TextExtractionTests.mm
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/SkipAdInPictureInPicture.mm
Log Message:
-----------
[TestWebKitAPI] Fix unified source build with CMake + internal SDK
https://bugs.webkit.org/show_bug.cgi?id=317109
rdar://179677961
Reviewed by Richard Robinson.
For build speed optimization, the CMake build dynamically resizes
unified sources. Fix naming collisions and duplicate declaration errors
that only appear when building from CMake with an internal macOS SDK:
When MediaSession.mm and NowPlaying.mm are bundled together, they
duplicate each other's MediaRemote soft-link declarations. Pull the
soft-linking out to its own file and deduplicate.
* Tools/TestWebKitAPI/Helpers/cocoa/MediaRemoteSoftLink.h: Added.
* Tools/TestWebKitAPI/Helpers/cocoa/MediaRemoteSoftLink.mm: Added.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/MediaSession.mm:
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/NowPlaying.mm:
* Tools/TestWebKitAPI/SourcesCocoa.txt:
Deduplicate a declaration granting write access to a property on
STWebpageController by pulling it into its own header.
* Tools/TestWebKitAPI/Helpers/cocoa/ScreenTimeExtras.h: Added.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/ScreenTime.mm:
(-[STPictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
(TEST(ScreenTime, URLIsPictureInPicture)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/TextExtractionTests.mm:
Remaining changes are renames of variables and static methods.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/AdaptiveImageGlyph.mm:
(readRTFDDataFromPasteboard):
(TestWebKitAPI::TEST(AdaptiveImageGlyph, CopyRTF)):
(readRTFDataFromPasteboard): Deleted.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/Badging.mm:
((Badging, DedicatedWorker)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/MediaMutedState.mm:
(-[AudioStateObserver observeValueForKeyPath:ofObject:change:context:]):
(TestWebKitAPI::TEST(WKWebView, MediaMuted)):
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/mac/SkipAdInPictureInPicture.mm:
(-[SkipAdInPiPFullscreenDelegate
_webView:hasVideoInPictureInPictureDidChange:]):
(TestWebKitAPI::TEST(SkipAdInPictureInPicture, VideoHasAd)):
(TestWebKitAPI::TEST(SkipAdInPictureInPicture, VideoHasNoAd)):
Canonical link: https://commits.webkit.org/315252@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
