Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 734f002a22a020e212940a0583c09ff055dbd33b
      
https://github.com/WebKit/WebKit/commit/734f002a22a020e212940a0583c09ff055dbd33b
  Author: Alex Christensen <[email protected]>
  Date:   2026-06-15 (Mon, 15 Jun 2026)

  Changed paths:
    M Source/cmake/WebKitXcodeSDK.cmake

  Log Message:
  -----------
  Fix cmake builds on Mac without using presets
https://bugs.webkit.org/show_bug.cgi?id=317131
rdar://179730255

Reviewed by Elliott Williams.

Before 314875@main I used to be able to just run cmake -G Ninja
and it worked, defaulting to a Mac build with the non-internal SDK
because of these lines in WebKitCommon.cmake:

if (APPLE AND PORT STREQUAL "NOPORT")
    set(PORT "Mac" CACHE STRING "choose which WebKit port to build (one of 
${ALL_PORTS})" FORCE)

After that change, it failed with this error:

CMake Error at Source/cmake/WebKitXcodeSDK.cmake:105 (message):
 Building for an Apple platform without an SDK directory (CMAKE_OSX_SYSROOT)
 or a hard-coded PORT provided.

This small change makes it so that if PORT is not specified on a
Darwin operating system, we continue to assume you are building
the Mac port.

* Source/cmake/WebKitXcodeSDK.cmake:

Canonical link: https://commits.webkit.org/315260@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to