Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f63c9ccf7f3ee286416db40cbe9b5f7d65ea496b
https://github.com/WebKit/WebKit/commit/f63c9ccf7f3ee286416db40cbe9b5f7d65ea496b
Author: Charlie Wolfe <[email protected]>
Date: 2026-06-16 (Tue, 16 Jun 2026)
Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm
Log Message:
-----------
PDFPluginChoiceAnnotation compares NSString choices by pointer instead of
value
https://bugs.webkit.org/show_bug.cgi?id=317164
rdar://179755604
Reviewed by Abrar Rahman Protyasha.
createAnnotationElement() compared each choice (NSString *) against
selectedChoice
(RetainPtr<NSString>) with ==, which resolves to RetainPtr's pointer comparison
rather than
string-content comparison. Use -isEqualToString:.
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):
Canonical link: https://commits.webkit.org/315290@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
