Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9ca51e149f7084e2a6becbc0a4483035d27393ae
https://github.com/WebKit/WebKit/commit/9ca51e149f7084e2a6becbc0a4483035d27393ae
Author: Brandon Stewart <[email protected]>
Date: 2026-06-16 (Tue, 16 Jun 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKAttachmentTests.mm
Log Message:
-----------
[CMake] Build fix macOS
https://bugs.webkit.org/show_bug.cgi?id=317213
rdar://179833790
Reviewed by Geoffrey Garen and Charlie Wolfe.
What was wrong
The recently added test
WKAttachmentTestsMac.RegisterAttachmentIdentifierFromFilePathWithUnauthorizedPathTerminatesProcess
(commit c6cd4e07e9af) in
Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKAttachmentTests.mm calls
[WKPreferences _features] and -_setEnabled:forFeature:, but the file never
imported the header that
declares them. With -Werror,-Wobjc-method-access, the missing declarations
became hard errors:
error: class method '+_features' not found
error: instance method '-_setEnabled:forFeature:' not found
Fix
Added the missing SPI import (_features/_setEnabled:forFeature: are declared in
WKPreferencesPrivate.h), in alphabetical order with the existing WebKit/
imports:
This matches how other tests using _features (e.g. EventAttribution.mm,
TextExtractionTests.mm) pull it in.
* Tools/TestWebKitAPI/Tests/WebKit/WKWebView/WKAttachmentTests.mm
Canonical link: https://commits.webkit.org/315299@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
