Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b0273bc189c1f6ddbfbb624d6cbe3b9f44e345d3
      
https://github.com/WebKit/WebKit/commit/b0273bc189c1f6ddbfbb624d6cbe3b9f44e345d3
  Author: Charlie Wolfe <[email protected]>
  Date:   2026-06-16 (Tue, 16 Jun 2026)

  Changed paths:
    A 
LayoutTests/storage/storagemanager/resources/worker-close-with-pending-estimate.js
    A 
LayoutTests/storage/storagemanager/worker-close-with-pending-estimate-expected.txt
    A LayoutTests/storage/storagemanager/worker-close-with-pending-estimate.html
    M Source/WebCore/Modules/storage/WorkerStorageConnection.cpp

  Log Message:
  -----------
  WorkerStorageConnection::scopeClosed() leaves getEstimate() completion 
handlers uncalled
https://bugs.webkit.org/show_bug.cgi?id=317050
rdar://179531657

Reviewed by Sihui Liu.

scopeClosed() drained m_getPersistedCallbacks and m_getDirectoryCallbacks but 
not
m_getEstimateCallbacks. An in-flight
StorageManager.estimate() at worker teardown therefore
destroyed an unrun CompletionHandler. Drain the estimate callbacks with an 
InvalidStateError too.

Test: storage/storagemanager/worker-close-with-pending-estimate.html
* 
LayoutTests/storage/storagemanager/resources/worker-close-with-pending-estimate.js:
 Added.
* 
LayoutTests/storage/storagemanager/worker-close-with-pending-estimate-expected.txt:
 Added.
* LayoutTests/storage/storagemanager/worker-close-with-pending-estimate.html: 
Added.
* Source/WebCore/Modules/storage/WorkerStorageConnection.cpp:
(WebCore::WorkerStorageConnection::scopeClosed):

Canonical link: 
https://flagged.apple.com:443/proxy?t2=Dn0U1U8jc5&o=aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvMzE1MzA3QG1haW4=&emid=1a79d9ac-b34c-45db-ab36-83f8457dff80&c=11



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to