Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b5ba38a21e172faaa8ca36fe615de89d9a1c93eb
https://github.com/WebKit/WebKit/commit/b5ba38a21e172faaa8ca36fe615de89d9a1c93eb
Author: Charlie Wolfe <[email protected]>
Date: 2026-06-16 (Tue, 16 Jun 2026)
Changed paths:
A LayoutTests/media/context-menu-download-media-uses-media-url-expected.txt
A LayoutTests/media/context-menu-download-media-uses-media-url.html
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/page/ContextMenuController.cpp
Log Message:
-----------
Download Media context-menu item checks the image URL instead of the media URL
https://bugs.webkit.org/show_bug.cgi?id=317174
rdar://179764378
Reviewed by Abrar Rahman Protyasha.
In the ContextMenuItemTagDownloadMediaToDisk case the disable check checked
absoluteImageURL().protocolIsFile() instead of absoluteMediaURL(). The
media-download item therefore
makes its enable/disable decision against the wrong URL.
Check absoluteMediaURL() so the item tracks the URL it actually downloads.
Test: media/context-menu-download-media-uses-media-url.html
* LayoutTests/media/context-menu-download-media-uses-media-url-expected.txt:
Added.
* LayoutTests/media/context-menu-download-media-uses-media-url.html: Added.
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
Canonical link: https://commits.webkit.org/315311@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
