Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 70753442a3d86ab5085352b3f3a8072c6733c7f3
https://github.com/WebKit/WebKit/commit/70753442a3d86ab5085352b3f3a8072c6733c7f3
Author: Ryosuke Niwa <[email protected]>
Date: 2026-06-16 (Tue, 16 Jun 2026)
Changed paths:
A LayoutTests/fast/html/dialog-close-from-button-crash-expected.txt
A LayoutTests/fast/html/dialog-close-from-button-crash.html
M Source/WebCore/html/HTMLDialogElement.cpp
Log Message:
-----------
Use-after-free in HTMLDialogElement::close
https://bugs.webkit.org/show_bug.cgi?id=312180
rdar://174525336
Reviewed by Geoffrey Garen.
Fix the bug in HTMLDialogElement::handleCommandInternal by storing the String
value
of the invoker in a local variable.
Test: fast/html/dialog-close-from-button-crash.html
* LayoutTests/fast/html/dialog-close-from-button-crash-expected.txt: Added.
* LayoutTests/fast/html/dialog-close-from-button-crash.html: Added.
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::handleCommandInternal):
Originally-landed-as: 305413.656@rapid/safari-7624.2.5.110-branch
(d986891db87d). rdar://176058778
Canonical link: https://commits.webkit.org/315325@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
