[webkit-changes] [WebKit/WebKit] 42e97c: [CMake][Mac] Add straggler files to the unified bu...

geoffreygaren Tue, 16 Jun 2026 15:37:32 -0700

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42e97c29d4e528aa1814d03877a5aae41de3e852
      
https://github.com/WebKit/WebKit/commit/42e97c29d4e528aa1814d03877a5aae41de3e852
  Author: Geoffrey Garen <[email protected]>
  Date:   2026-06-16 (Tue, 16 Jun 2026)


  Changed paths:
    M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceCocoa.cpp
    M Source/WebCore/PlatformCocoa.cmake
    A Source/WebCore/SourcesCMakeCocoa.txt
    M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
    M Source/WebCore/platform/graphics/cocoa/CMUtilities.mm
    M Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm
    M Source/WebCore/platform/ios/WebAVPlayerController.mm
    M Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm
    M Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUtilitiesCocoa.mm
    M Source/WebKit/PlatformCocoa.cmake
    M Source/WebKit/Shared/Cocoa/CoreIPCPlistObject.mm
    A Source/WebKit/SourcesCMakeCocoa.txt
    M Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp
    M Source/WebKit/UIProcess/WebAuthentication/fido/FidoService.cpp
    M Source/WebKitLegacy/PlatformCocoa.cmake
    M Source/WebKitLegacy/PlatformMac.cmake
    A Source/WebKitLegacy/SourcesCMakeCocoa.txt
    M Source/WebKitLegacy/WebCoreSupport/WebViewGroup.mm
    M Source/WebKitLegacy/mac/History/BackForwardList.mm
    M Source/WebKitLegacy/mac/History/HistoryPropertyList.mm
    M Source/WebKitLegacy/mac/History/WebHistory.mm
    M Source/WebKitLegacy/mac/History/WebHistoryItem.mm
    M Source/WebKitLegacy/mac/Misc/WebCoreStatistics.mm
    M Source/WebKitLegacy/mac/Misc/WebDownload.mm
    M Source/WebKitLegacy/mac/Misc/WebElementDictionary.mm
    M Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm
    M Source/WebKitLegacy/mac/Misc/WebKitLogInitialization.mm
    M Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm
    M Source/WebKitLegacy/mac/Misc/WebLocalizableStringsInternal.mm
    M Source/WebKitLegacy/mac/Misc/WebNSPasteboardExtras.mm
    M Source/WebKitLegacy/mac/Misc/WebUserContentURLPattern.mm
    M Source/WebKitLegacy/mac/Plugins/WebPluginPackage.mm
    M Source/WebKitLegacy/mac/Storage/WebDatabaseManager.mm
    M Source/WebKitLegacy/mac/Storage/WebDatabaseManagerClient.mm
    M Source/WebKitLegacy/mac/Storage/WebDatabaseQuotaManager.mm
    M Source/WebKitLegacy/mac/Storage/WebStorageManager.mm
    M Source/WebKitLegacy/mac/Storage/WebStorageTrackerClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebFrameNetworkingContext.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebGeolocationClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebKitFullScreenListener.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebMediaKeySystemClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebOpenPanelResultListener.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebPluginInfoProvider.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebProgressTrackerClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOrigin.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebSelectionServiceController.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebValidationMessageClient.mm
    M Source/WebKitLegacy/mac/WebCoreSupport/WebVisitedLinkStore.mm
    M Source/WebKitLegacy/mac/WebInspector/WebInspectorFrontend.mm
    M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.mm
    M Source/WebKitLegacy/mac/WebInspector/WebNodeHighlightView.mm
    M Source/WebKitLegacy/mac/WebView/WebArchive.mm
    M Source/WebKitLegacy/mac/WebView/WebDeviceOrientation.mm
    M Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.mm
    M Source/WebKitLegacy/mac/WebView/WebDocumentLoaderMac.mm
    M Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm
    M Source/WebKitLegacy/mac/WebView/WebGeolocationPosition.mm
    M Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm
    M Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
    M Source/WebKitLegacy/mac/WebView/WebIndicateLayer.mm
    M Source/WebKitLegacy/mac/WebView/WebNotification.mm
    M Source/WebKitLegacy/mac/WebView/WebPolicyDelegate.mm
    M Source/WebKitLegacy/mac/WebView/WebPreferences.mm
    M Source/WebKitLegacy/mac/WebView/WebResource.mm
    M Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm
    M Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  [CMake][Mac] Add straggler files to the unified build in 
WebKitLegacy/WebKit/WebCore
https://bugs.webkit.org/show_bug.cgi?id=317212
rdar://179833643

Reviewed by Mike Wyrzykowski.

Saves ~16s (5%) in a clean build.

Translation-unit counts:
  WebKitLegacy   131 ->  33
  WebKit         256 -> 126
  WebCore        238 -> 148
  Total          625 -> 307

This patch excludes iOS for now to reduce the build qualification burden.

* Source/WebCore/Modules/webaudio/MediaStreamAudioSourceCocoa.cpp: Unified 
build name
ambiguity fix.

* Source/WebCore/PlatformCocoa.cmake: Include the new unified source list in 
the build.

* Source/WebCore/SourcesCMakeCocoa.txt: New unified source list.

* Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm: Drop using namespace 
WebCore
to avoid unified name collisions.

* Source/WebCore/platform/graphics/cocoa/CMUtilities.mm
* Source/WebCore/platform/graphics/cocoa/WebMAudioUtilitiesCocoa.mm
* Source/WebCore/platform/ios/WebAVPlayerController.mm
* Source/WebCore/platform/mac/PlaybackSessionInterfaceMac.mm
* Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp
* Source/WebKit/NetworkProcess/webrtc/NetworkRTCUtilitiesCocoa.mm: Use #ifdefs 
and/or #undef
to guard double definition.

* Source/WebKit/PlatformCocoa.cmake: Include the new unified source list in the 
build.

* Source/WebKit/Shared/Cocoa/CoreIPCPlistObject.mm: Avoid name conflict in the 
unified
build.

* Source/WebKit/SourcesCMakeCocoa.txt: New unified source list.

* Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp
* Source/WebKit/UIProcess/WebAuthentication/fido/FidoService.cpp: Use #ifdefs 
and/or #undef
to guard double definition.

* Source/WebKitLegacy/PlatformCocoa.cmake: Include the new unified source list 
in the build.

* Source/WebKitLegacy/SourcesCMakeCocoa.txt: New unified source list.

* Source/WebKitLegacy/WebCoreSupport/WebViewGroup.mm
* Source/WebKitLegacy/mac/History/BackForwardList.mm
* Source/WebKitLegacy/mac/History/HistoryPropertyList.mm
* Source/WebKitLegacy/mac/History/WebHistory.mm
* Source/WebKitLegacy/mac/History/WebHistoryItem.mm
* Source/WebKitLegacy/mac/Misc/WebCoreStatistics.mm
* Source/WebKitLegacy/mac/Misc/WebDownload.mm
* Source/WebKitLegacy/mac/Misc/WebElementDictionary.mm
* Source/WebKitLegacy/mac/Misc/WebIconDatabase.mm
* Source/WebKitLegacy/mac/Misc/WebKitLogInitialization.mm
* Source/WebKitLegacy/mac/Misc/WebKitNSStringExtras.mm
* Source/WebKitLegacy/mac/Misc/WebLocalizableStringsInternal.mm
* Source/WebKitLegacy/mac/Misc/WebNSPasteboardExtras.mm
* Source/WebKitLegacy/mac/Misc/WebUserContentURLPattern.mm
* Source/WebKitLegacy/mac/Plugins/WebPluginPackage.mm
* Source/WebKitLegacy/mac/Storage/WebDatabaseManager.mm
* Source/WebKitLegacy/mac/Storage/WebDatabaseManagerClient.mm
* Source/WebKitLegacy/mac/Storage/WebDatabaseQuotaManager.mm
* Source/WebKitLegacy/mac/Storage/WebStorageManager.mm
* Source/WebKitLegacy/mac/Storage/WebStorageTrackerClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/CorrectionPanel.mm
* Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebAlternativeTextClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebDragClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebFrameNetworkingContext.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebGeolocationClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebKitFullScreenListener.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebMediaKeySystemClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebNotificationClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebOpenPanelResultListener.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebPluginInfoProvider.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebProgressTrackerClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebSecurityOrigin.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebSelectionServiceController.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebValidationMessageClient.mm
* Source/WebKitLegacy/mac/WebCoreSupport/WebVisitedLinkStore.mm
* Source/WebKitLegacy/mac/WebInspector/WebInspectorFrontend.mm
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlight.mm
* Source/WebKitLegacy/mac/WebInspector/WebNodeHighlightView.mm
* Source/WebKitLegacy/mac/WebView/WebArchive.mm
* Source/WebKitLegacy/mac/WebView/WebDeviceOrientation.mm
* Source/WebKitLegacy/mac/WebView/WebDeviceOrientationProviderMock.mm
* Source/WebKitLegacy/mac/WebView/WebDocumentLoaderMac.mm
* Source/WebKitLegacy/mac/WebView/WebDynamicScrollBarsView.mm
* Source/WebKitLegacy/mac/WebView/WebGeolocationPosition.mm
* Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm
* Source/WebKitLegacy/mac/WebView/WebHTMLView.mm
* Source/WebKitLegacy/mac/WebView/WebIndicateLayer.mm
* Source/WebKitLegacy/mac/WebView/WebNotification.mm
* Source/WebKitLegacy/mac/WebView/WebPolicyDelegate.mm
* Source/WebKitLegacy/mac/WebView/WebPreferences.mm
* Source/WebKitLegacy/mac/WebView/WebResource.mm
* Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm
* Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm: Drop using 
namespace
WebCore, and use WebCore::, to prevent name conflicts when bundling.

* Source/WebKitLegacy/mac/WebView/WebVideoFullscreenController.mm
* Source/WebKitLegacy/mac/WebView/WebView.mm: Use #ifdef guards to avoid 
duplicate
definition when bundling.

Canonical link: https://commits.webkit.org/315332@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

[webkit-changes] [WebKit/WebKit] 42e97c: [CMake][Mac] Add straggler files to the unified bu...

Reply via email to