Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 35d4680bcc0484c6cb93b517b91ab0299ca29583
https://github.com/WebKit/WebKit/commit/35d4680bcc0484c6cb93b517b91ab0299ca29583
Author: Charlie Wolfe <[email protected]>
Date: 2026-06-16 (Tue, 16 Jun 2026)
Changed paths:
M Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp
Log Message:
-----------
WebResourceLoadObserver::logSubresourceLoading dereferences frame in an
ASSERT placed before its null check
https://bugs.webkit.org/show_bug.cgi?id=317215
rdar://179837745
Reviewed by Chris Dumez.
logSubresourceLoading() guards against a null frame with an early return, but
ASSERT(frame->page())
was placed two lines above that guard, so in assert-enabled builds a null frame
is dereferenced
before the guard can run. Move the null frame check above the page access, and
assert on the
already-fetched page RefPtr right before its null check rather than calling
frame->page() twice.
* Source/WebKit/WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:
(WebKit::WebResourceLoadObserver::logSubresourceLoading):
Canonical link: https://commits.webkit.org/315344@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
