Title: [115124] trunk/Tools
- Revision
- 115124
- Author
- [email protected]
- Date
- 2012-04-24 15:46:32 -0700 (Tue, 24 Apr 2012)
Log Message
Replace vague informative statement with the list of builders where the test isn't listed
https://bugs.webkit.org/show_bug.cgi?id=84779
Reviewed by Dirk Pranke.
This is more informative and more likely to be noticed. With the old UI, people never
read the line and if they did, they didn't really understand what it meant. Hopefully
have the list of builders will be more clear.
* TestResultServer/static-dashboards/flakiness_dashboard.js:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (115123 => 115124)
--- trunk/Tools/ChangeLog 2012-04-24 22:44:43 UTC (rev 115123)
+++ trunk/Tools/ChangeLog 2012-04-24 22:46:32 UTC (rev 115124)
@@ -1,3 +1,18 @@
+2012-04-24 Ojan Vafai <[email protected]>
+
+ Replace vague informative statement with the list of builders where the test isn't listed
+ https://bugs.webkit.org/show_bug.cgi?id=84779
+
+ Reviewed by Dirk Pranke.
+
+ This is more informative and more likely to be noticed. With the old UI, people never
+ read the line and if they did, they didn't really understand what it meant. Hopefully
+ have the list of builders will be more clear.
+
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
+ * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
+
2012-04-24 Tommy Widenflycht <[email protected]>
MediaStream API: Create a new flag for PeerConnection
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (115123 => 115124)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-04-24 22:44:43 UTC (rev 115123)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2012-04-24 22:46:32 UTC (rev 115124)
@@ -1537,20 +1537,29 @@
processTestRunsForAllBuilders();
var testResults = g_testToResultsMap[test];
+ if (!testResults)
+ return '<div class="not-found">Test not found. Either it does not exist, is skipped or passes on all platforms.</div>';
+
var html = '';
- if (testResults) {
- html +='<div><b>If a builder is not listed, that means the builder ' +
- 'does not run that test (e.g. it is skipped) or all runs of the ' +
- 'test passed.</b></div>';
+ var shownBuilders = [];
+ for (var j = 0; j < testResults.length; j++) {
+ shownBuilders.push(testResults[j].builder);
+ html += htmlForSingleTestRow(testResults[j]);
+ }
- for (var j = 0; j < testResults.length; j++)
- html += htmlForSingleTestRow(testResults[j]);
- html = htmlForTestTable(html);
- } else {
- html += '<div class="not-found">Test not found. Either it does ' +
- 'not exist, is skipped or passes on all platforms.</div>';
+ var skippedBuilders = []
+ for (builder in currentBuilderGroup().builders) {
+ if (shownBuilders.indexOf(builder) == -1)
+ skippedBuilders.push(builder);
}
- return html;
+
+ var skippedBuildersHtml = '';
+ if (skippedBuilders.length) {
+ skippedBuildersHtml = '<div>The following builders either don\'t run this test (e.g. it\'s skipped) or all runs passed:</div>' +
+ '<div class=skipped-builder-list><div class=skipped-builder>' + skippedBuilders.join('</div><div class=skipped-builder>') + '</div></div>';
+ }
+
+ return htmlForTestTable(html) + skippedBuildersHtml;
}
function htmlForIndividualTestOnAllBuildersWithChrome(test)
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.css (115123 => 115124)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.css 2012-04-24 22:44:43 UTC (rev 115123)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.css 2012-04-24 22:46:32 UTC (rev 115124)
@@ -106,7 +106,7 @@
}
.test-table .wrong-expectations,
.wrong-expectations {
- background-color: #pink;
+ background-color: pink;
}
.P {
background-color: #8fdf5f;
@@ -260,3 +260,19 @@
.expectations-item:hover .pngchecksum {
visibility: visible;
}
+.skipped-builder-list {
+ margin-left: 20px;
+ background-color: #E8E8E8;
+}
+.skipped-builder {
+ display: inline-block;
+ white-space: nowrap;
+}
+.skipped-builder:after {
+ content: '|';
+ margin: 5px;
+}
+.skipped-builder:last-child:after {
+ content: '';
+}
+
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js (115123 => 115124)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-04-24 22:44:43 UTC (rev 115123)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js 2012-04-24 22:46:32 UTC (rev 115124)
@@ -415,10 +415,25 @@
'<th sortValue=%><div class=table-header-content><span></span><span class=header-text>% fail</span></div></th>' +
'<th sortValue=flakiness colspan=10000><div class=table-header-content><span></span><span class=header-text>flakiness (numbers are runtimes in seconds)</span></div></th>' +
'</tr></thead>' +
- '<tbody>' +
- '<div><b>If a builder is not listed, that means the builder does not run that test (e.g. it is skipped) or all runs of the test passed.</b></div>' +
- '</tbody>' +
+ '<tbody></tbody>' +
'</table>' +
+ '<div>The following builders either don\'t run this test (e.g. it\'s skipped) or all runs passed:</div>' +
+ '<div class=skipped-builder-list>' +
+ '<div class=skipped-builder>Webkit Linux</div>' +
+ '<div class=skipped-builder>Webkit Linux (dbg)</div>' +
+ '<div class=skipped-builder>Webkit Linux 32</div>' +
+ '<div class=skipped-builder>Webkit Mac10.5</div>' +
+ '<div class=skipped-builder>Webkit Mac10.5 (dbg)(1)</div>' +
+ '<div class=skipped-builder>Webkit Mac10.5 (dbg)(2)</div>' +
+ '<div class=skipped-builder>Webkit Mac10.6</div>' +
+ '<div class=skipped-builder>Webkit Mac10.6 (dbg)</div>' +
+ '<div class=skipped-builder>Webkit Mac10.7</div>' +
+ '<div class=skipped-builder>Webkit Vista</div>' +
+ '<div class=skipped-builder>Webkit Win</div>' +
+ '<div class=skipped-builder>Webkit Win (dbg)(1)</div>' +
+ '<div class=skipped-builder>Webkit Win (dbg)(2)</div>' +
+ '<div class=skipped-builder>Webkit Win7</div>' +
+ '</div>' +
'<div class=expectations test=dummytest.html>' +
'<div><span class=link _onclick_="setQueryParameter(\'showExpectations\', true)">Show results</span> | ' +
'<span class=link _onclick_="setQueryParameter(\'showLargeExpectations\', true)">Show large thumbnails</span> | ' +
@@ -443,10 +458,25 @@
'<th sortValue=%><div class=table-header-content><span></span><span class=header-text>% fail</span></div></th>' +
'<th sortValue=flakiness colspan=10000><div class=table-header-content><span></span><span class=header-text>flakiness (numbers are runtimes in seconds)</span></div></th>' +
'</tr></thead>' +
- '<tbody>' +
- '<div><b>If a builder is not listed, that means the builder does not run that test (e.g. it is skipped) or all runs of the test passed.</b></div>' +
- '</tbody>' +
+ '<tbody></tbody>' +
'</table>' +
+ '<div>The following builders either don\'t run this test (e.g. it\'s skipped) or all runs passed:</div>' +
+ '<div class=skipped-builder-list>' +
+ '<div class=skipped-builder>Webkit Linux</div>' +
+ '<div class=skipped-builder>Webkit Linux (dbg)</div>' +
+ '<div class=skipped-builder>Webkit Linux 32</div>' +
+ '<div class=skipped-builder>Webkit Mac10.5</div>' +
+ '<div class=skipped-builder>Webkit Mac10.5 (dbg)(1)</div>' +
+ '<div class=skipped-builder>Webkit Mac10.5 (dbg)(2)</div>' +
+ '<div class=skipped-builder>Webkit Mac10.6</div>' +
+ '<div class=skipped-builder>Webkit Mac10.6 (dbg)</div>' +
+ '<div class=skipped-builder>Webkit Mac10.7</div>' +
+ '<div class=skipped-builder>Webkit Vista</div>' +
+ '<div class=skipped-builder>Webkit Win</div>' +
+ '<div class=skipped-builder>Webkit Win (dbg)(1)</div>' +
+ '<div class=skipped-builder>Webkit Win (dbg)(2)</div>' +
+ '<div class=skipped-builder>Webkit Win7</div>' +
+ '</div>' +
'<div class=expectations test=dummytest.html>' +
'<div><span class=link _onclick_="setQueryParameter(\'showExpectations\', true)">Show results</span> | ' +
'<span class=link _onclick_="setQueryParameter(\'showLargeExpectations\', true)">Show large thumbnails</span>' +
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
