Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 40fd5ae0d75b44b446d33fd2e13a9b6dede06a96
https://github.com/WebKit/WebKit/commit/40fd5ae0d75b44b446d33fd2e13a9b6dede06a96
Author: Sosuke Suzuki <[email protected]>
Date: 2026-06-18 (Thu, 18 Jun 2026)
Changed paths:
M Source/JavaScriptCore/runtime/TemporalDuration.cpp
M Source/JavaScriptCore/runtime/TemporalDuration.h
M Source/JavaScriptCore/runtime/temporal/core/CalendarICUBridge.cpp
Log Message:
-----------
[JSC][Temporal] Check `ucal_add` failure in `calendarDateFromFields` and
remove dead `combineISODateAndTimeRecord`
https://bugs.webkit.org/show_bug.cgi?id=317069
Reviewed by Yijia Huang.
This patch cleans up two leftovers from recent Temporal refactorings:
1. The lunisolar monthCode path of calendarDateFromFields adjusts the day
of month via ucal_add but never checks the resulting status. This was
the only remaining unchecked status-taking ICU call in
CalendarICUBridge.cpp / TimeZoneICUBridge.cpp after the ICU error
handling was made strict. On the constrain path the status is not
re-checked afterwards, so a failure would be silently swallowed and the
first day of the resolved month would be returned. Add the same
U_FAILURE check used by the surrounding ucal_add calls.
2. TemporalDuration::combineISODateAndTimeRecord became a dead one-line
delegate (it just returns { isoDate, isoTime }) after the one-line
TemporalCore delegate wrappers were removed; it has no callers left.
Remove the definition and declaration.
* Source/JavaScriptCore/runtime/TemporalDuration.cpp:
(JSC::TemporalDuration::combineISODateAndTimeRecord): Deleted.
* Source/JavaScriptCore/runtime/TemporalDuration.h:
* Source/JavaScriptCore/runtime/temporal/core/CalendarICUBridge.cpp:
(JSC::TemporalCore::calendarDateFromFields):
Canonical link: https://commits.webkit.org/315456@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
