Title: [115140] trunk/LayoutTests
- Revision
- 115140
- Author
- [email protected]
- Date
- 2012-04-24 16:59:14 -0700 (Tue, 24 Apr 2012)
Log Message
Fix layout test failures for Oscillator because WaveTable now normalizes to 0dBFS instead of -6dbFS
https://bugs.webkit.org/show_bug.cgi?id=84799
Reviewed by James Robinson.
This fixes failures caused by: http://trac.webkit.org/changeset/115111
We need to adjust the layout test itself to scale by 1/2 to compensate for the new WaveTable normalization.
The reason we don't change the audio .wav file baselines themselves is because audio values can potentially
clip past full scale, and we need to be able to avoid this "overshoot".
* webaudio/resources/oscillator-testing.js:
(generateExponentialOscillatorSweep):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (115139 => 115140)
--- trunk/LayoutTests/ChangeLog 2012-04-24 23:58:04 UTC (rev 115139)
+++ trunk/LayoutTests/ChangeLog 2012-04-24 23:59:14 UTC (rev 115140)
@@ -1,3 +1,18 @@
+2012-04-24 Chris Rogers <[email protected]>
+
+ Fix layout test failures for Oscillator because WaveTable now normalizes to 0dBFS instead of -6dbFS
+ https://bugs.webkit.org/show_bug.cgi?id=84799
+
+ Reviewed by James Robinson.
+
+ This fixes failures caused by: http://trac.webkit.org/changeset/115111
+ We need to adjust the layout test itself to scale by 1/2 to compensate for the new WaveTable normalization.
+ The reason we don't change the audio .wav file baselines themselves is because audio values can potentially
+ clip past full scale, and we need to be able to avoid this "overshoot".
+
+ * webaudio/resources/oscillator-testing.js:
+ (generateExponentialOscillatorSweep):
+
2012-04-24 Alexandru Chiculita <[email protected]>
CSS Shaders: Repainting the FECustomFilter requires full source image
Modified: trunk/LayoutTests/webaudio/resources/oscillator-testing.js (115139 => 115140)
--- trunk/LayoutTests/webaudio/resources/oscillator-testing.js 2012-04-24 23:58:04 UTC (rev 115139)
+++ trunk/LayoutTests/webaudio/resources/oscillator-testing.js 2012-04-24 23:59:14 UTC (rev 115140)
@@ -41,7 +41,11 @@
osc.type = oscillatorType;
}
- osc.connect(context.destination);
+ // Scale by 1/2 to better visualize the waveform and to avoid clipping past full scale.
+ var gainNode = context.createGainNode();
+ gainNode.gain.value = 0.5;
+ osc.connect(gainNode);
+ gainNode.connect(context.destination);
var nyquist = 0.5 * sampleRate;
osc.frequency.setValueAtTime(10, 0);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
