Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7f1da39fa5e890a99e1d24511132c32848d503ef
https://github.com/WebKit/WebKit/commit/7f1da39fa5e890a99e1d24511132c32848d503ef
Author: Sammy Gill <[email protected]>
Date: 2026-06-18 (Thu, 18 Jun 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-008-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-008.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-009-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-009.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-010-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-010.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-012-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-012.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-013-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-013.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-001-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-001-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-001.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-002-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-002-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-002.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-003-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-003-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-003.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-004-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-004-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-004.html
M Source/WebCore/layout/integration/grid/LayoutIntegrationGridLayout.cpp
Log Message:
-----------
[GFC] Items have incorrect position within the grid's border box.
https://bugs.webkit.org/show_bug.cgi?id=317420
rdar://180047102
Reviewed by Alan Baradlay.
Grid items were positioned relative to the grid container's border box
instead of its content box. Offset by contentBoxLeft/contentBoxTop from
the grid box geometry so that border and padding are accounted for.
Update five abspos reftests so the previously-asserted positions
match the new (and cross-browser) behavior. With grid items now
correctly inset by the grid's padding, the static position of an abspos
descendant of a grid item also shifts by that padding -- which is what
Chrome and Firefox already render. The tests are reworded with outlines
on the grid container, grid item, and abspos box so the layout is
visually obvious, and their -expected.html files are rewritten as
self-contained references with matching outlines.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-001.html:
Added.
Border only
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-002.html:
Added.
Padding only
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-003.html:
Added.
Border + padding
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-border-padding-004.html:
Added.
Asymmetric border + padding
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-008.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-009.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-010.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-012.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-descendant-containing-block-013.html:
Add outlines on the grid container, grid item, and abspos box so the
layout is visually obvious; rewrite each -expected.html as a
self-contained reference using absolutely-positioned rectangles at
the spec-correct coordinates.
Canonical link: https://commits.webkit.org/315509@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
