Title: [115146] trunk/Tools
- Revision
- 115146
- Author
- [email protected]
- Date
- 2012-04-24 17:28:14 -0700 (Tue, 24 Apr 2012)
Log Message
nrwt: add ASAN handling to chromium crash logs
https://bugs.webkit.org/show_bug.cgi?id=84664
Reviewed by Ojan Vafai.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort._get_crash_log):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (115145 => 115146)
--- trunk/Tools/ChangeLog 2012-04-25 00:25:55 UTC (rev 115145)
+++ trunk/Tools/ChangeLog 2012-04-25 00:28:14 UTC (rev 115146)
@@ -1,5 +1,15 @@
2012-04-24 Dirk Pranke <[email protected]>
+ nrwt: add ASAN handling to chromium crash logs
+ https://bugs.webkit.org/show_bug.cgi?id=84664
+
+ Reviewed by Ojan Vafai.
+
+ * Scripts/webkitpy/layout_tests/port/chromium.py:
+ (ChromiumPort._get_crash_log):
+
+2012-04-24 Dirk Pranke <[email protected]>
+
webkit-patch rebaseline-test is retrieving stale expectations
https://bugs.webkit.org/show_bug.cgi?id=84762
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py (115145 => 115146)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-04-25 00:25:55 UTC (rev 115145)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium.py 2012-04-25 00:28:14 UTC (rev 115146)
@@ -333,6 +333,16 @@
repos.append(('chromium', self.path_from_chromium_base('build')))
return repos
+ def _get_crash_log(self, name, pid, stdout, stderr, newer_than):
+ new_stderr = stderr
+ if stderr and 'AddressSanitizer' in stderr:
+ asan_filter_path = self.path_from_chromium_base('third_party', 'asan', 'scripts', 'asan_symbolize.py')
+ if self._filesystem.exists(asan_filter_path):
+ output = self._executive.run_command([asan_filter_path], input=stderr)
+ new_stderr = self._executive.run_command(['c++filt'], input=output)
+
+ return super(ChromiumPort, self)._get_crash_log(name, pid, stdout, new_stderr, newer_than)
+
def virtual_test_suites(self):
return [
VirtualTestSuite('platform/chromium/virtual/gpu/fast/canvas',
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes