Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7ab8e34f2b262a4c0c50558afaa277a64670388a
https://github.com/WebKit/WebKit/commit/7ab8e34f2b262a4c0c50558afaa277a64670388a
Author: Jer Noble <[email protected]>
Date: 2026-06-20 (Sat, 20 Jun 2026)
Changed paths:
M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h
M Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm
M Source/WebCore/en.lproj/Localizable.strings
M Source/WebCore/html/track/InbandTextTrack.cpp
M Source/WebCore/html/track/InbandTextTrack.h
M Source/WebCore/html/track/TextTrack.h
M Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebCore/platform/graphics/InbandTextTrackPrivate.h
M
Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h
M
Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm
M Source/WebKit/GPUProcess/media/RemoteTextTrackProxy.cpp
M Source/WebKit/GPUProcess/media/TextTrackPrivateRemoteConfiguration.h
M
Source/WebKit/GPUProcess/media/TextTrackPrivateRemoteConfiguration.serialization.in
M Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.cpp
M Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.h
Log Message:
-----------
[Cocoa] Machine generated subtitles should be labeled as such
rdar://174772953
https://bugs.webkit.org/show_bug.cgi?id=316754
Reviewed by Eric Carlson.
Tracks that have the "machine generated" characteristic are labeled as
such by CaptionUserPreferencesMediaAF.
Pass the track's `isMachineGenerated` value up from the GPU process
to the WebContent process by way of RemoteTextTrackProxy/TextTrackPrivateRemote.
* Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h:
* Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm:
* Source/WebCore/en.lproj/Localizable.strings:
* Source/WebCore/html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::isMachineGenerated const):
* Source/WebCore/html/track/InbandTextTrack.h:
* Source/WebCore/html/track/TextTrack.h:
(WebCore::TextTrack::isMachineGenerated const):
* Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::addTextTrackKindDisplayNameIfNeeded):
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::textTrackKindGeneratedDisplayName):
(WebCore::addTextTrackKindGeneratedSuffix):
* Source/WebCore/platform/LocalizedStrings.h:
* Source/WebCore/platform/graphics/InbandTextTrackPrivate.h:
(WebCore::InbandTextTrackPrivate::isMachineGenerated const):
*
Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
*
Source/WebCore/platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
(WebCore::InbandTextTrackPrivateAVFObjC::isMachineGenerated const):
* Source/WebKit/GPUProcess/media/RemoteTextTrackProxy.cpp:
(WebKit::RemoteTextTrackProxy::configuration):
* Source/WebKit/GPUProcess/media/TextTrackPrivateRemoteConfiguration.h:
*
Source/WebKit/GPUProcess/media/TextTrackPrivateRemoteConfiguration.serialization.in:
* Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.cpp:
(WebKit::TextTrackPrivateRemote::updateConfiguration):
* Source/WebKit/WebProcess/GPU/media/TextTrackPrivateRemote.h:
Canonical link: https://commits.webkit.org/315564@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
