Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5b3364fd97cd3c58f7c0d5571b6ac594c909b049
https://github.com/WebKit/WebKit/commit/5b3364fd97cd3c58f7c0d5571b6ac594c909b049
Author: Taher Ali <[email protected]>
Date: 2026-06-22 (Mon, 22 Jun 2026)
Changed paths:
A LayoutTests/svg/filters/feImage-reentrant-filter-remove-crash-expected.txt
A LayoutTests/svg/filters/feImage-reentrant-filter-remove-crash.html
M Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceFilter.cpp
Log Message:
-----------
Revert 312304@main, which used a stale HashMap iterator in
LegacyRenderSVGResourceFilter::applyResource
https://bugs.webkit.org/show_bug.cgi?id=317445
rdar://177698242
Reviewed by Simon Fraser.
This reverts the source change from 312304@main, which removed map entries by
the iterator from set() to avoid re-hashing the key. applyResource() can be
re-entered recursively (SVGFilterRenderer::create() paints an feImage's
referenced subtree, which re-enters with another client and inserts into the
same map), rehashing it and invalidating that iterator, so removing by it is a
use-after-free. Restore removal by key, and add a regression test.
* LayoutTests/svg/filters/feImage-reentrant-filter-remove-crash-expected.txt:
Added.
* LayoutTests/svg/filters/feImage-reentrant-filter-remove-crash.html: Added.
* Source/WebCore/rendering/svg/legacy/LegacyRenderSVGResourceFilter.cpp:
(WebCore::LegacyRenderSVGResourceFilter::applyResource):
Canonical link: https://commits.webkit.org/315624@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
