Title: [115157] trunk
- Revision
- 115157
- Author
- [email protected]
- Date
- 2012-04-24 18:59:08 -0700 (Tue, 24 Apr 2012)
Log Message
ASSERT failure in RenderLayer::computeRepaintRects
https://bugs.webkit.org/show_bug.cgi?id=84480
Patch by Yong Li <[email protected]> on 2012-04-24
Reviewed by Simon Fraser.
Source/WebCore:
Update visibility status if necessary before updating
compositing state in RenderLayer::styleChanged().
No new tests because this is obviously right thing to do
and creating new test seems too much for this small change.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
LayoutTests:
Add a layout test for it.
* compositing/visibility/compositing-and-visibility-turned-off-together-expected.txt: Added.
* compositing/visibility/compositing-and-visibility-turned-off-together.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (115156 => 115157)
--- trunk/LayoutTests/ChangeLog 2012-04-25 01:29:42 UTC (rev 115156)
+++ trunk/LayoutTests/ChangeLog 2012-04-25 01:59:08 UTC (rev 115157)
@@ -1,3 +1,15 @@
+2012-04-24 Yong Li <[email protected]>
+
+ ASSERT failure in RenderLayer::computeRepaintRects
+ https://bugs.webkit.org/show_bug.cgi?id=84480
+
+ Reviewed by Simon Fraser.
+
+ Add a layout test for it.
+
+ * compositing/visibility/compositing-and-visibility-turned-off-together-expected.txt: Added.
+ * compositing/visibility/compositing-and-visibility-turned-off-together.html: Added.
+
2012-04-24 Kent Tamura <[email protected]>
Calendar Picker: Open a calendar picker by keyboard operation
Added: trunk/LayoutTests/compositing/visibility/compositing-and-visibility-turned-off-together-expected.txt (0 => 115157)
--- trunk/LayoutTests/compositing/visibility/compositing-and-visibility-turned-off-together-expected.txt (rev 0)
+++ trunk/LayoutTests/compositing/visibility/compositing-and-visibility-turned-off-together-expected.txt 2012-04-25 01:59:08 UTC (rev 115157)
@@ -0,0 +1,3 @@
+This test verifies no assertion failure is raised when visibility and need for compositing are turned off at same time.
+
+
Added: trunk/LayoutTests/compositing/visibility/compositing-and-visibility-turned-off-together.html (0 => 115157)
--- trunk/LayoutTests/compositing/visibility/compositing-and-visibility-turned-off-together.html (rev 0)
+++ trunk/LayoutTests/compositing/visibility/compositing-and-visibility-turned-off-together.html 2012-04-25 01:59:08 UTC (rev 115157)
@@ -0,0 +1,26 @@
+<html>
+<head>
+<script>
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.waitUntilDone();
+}
+function dotest()
+{
+ document.getElementById('theelement').style.setProperty('visibility','hidden','');
+ document.getElementById('theelement').style.removeProperty('-webkit-perspective');
+
+ // force layout
+ document.body.offsetTop;
+
+ if (window.layoutTestController)
+ layoutTestController.notifyDone();
+}
+</script>
+</head>
+<body _onload_="setTimeout(dotest,0)">
+<p>This test verifies no assertion failure is raised when visibility and need for compositing are turned off at same time.</p>
+
+<div id="theelement" class="abstop" style="position: absolute; -webkit-perspective: 1">This line should be invisible</div>
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (115156 => 115157)
--- trunk/Source/WebCore/ChangeLog 2012-04-25 01:29:42 UTC (rev 115156)
+++ trunk/Source/WebCore/ChangeLog 2012-04-25 01:59:08 UTC (rev 115157)
@@ -1,3 +1,19 @@
+2012-04-24 Yong Li <[email protected]>
+
+ ASSERT failure in RenderLayer::computeRepaintRects
+ https://bugs.webkit.org/show_bug.cgi?id=84480
+
+ Reviewed by Simon Fraser.
+
+ Update visibility status if necessary before updating
+ compositing state in RenderLayer::styleChanged().
+
+ No new tests because this is obviously right thing to do
+ and creating new test seems too much for this small change.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::styleChanged):
+
2012-04-24 Kent Tamura <[email protected]>
Calendar Picker: Open a calendar picker by keyboard operation
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (115156 => 115157)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-04-25 01:29:42 UTC (rev 115156)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-04-25 01:59:08 UTC (rev 115157)
@@ -4741,6 +4741,7 @@
#endif
#if USE(ACCELERATED_COMPOSITING)
+ updateVisibilityStatus();
updateTransform();
if (compositor()->updateLayerCompositingState(this))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
