Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ca1771c2c9764dfe8efefc4e12a389678e0be88a
https://github.com/WebKit/WebKit/commit/ca1771c2c9764dfe8efefc4e12a389678e0be88a
Author: Mike Wyrzykowski <[email protected]>
Date: 2026-06-23 (Tue, 23 Jun 2026)
Changed paths:
M Source/WebKit/WebProcess/Model/WebModelPlayer.mm
Log Message:
-----------
Model element: get() used in places where ptr() should be used
https://bugs.webkit.org/show_bug.cgi?id=317660
rdar://180421888
Reviewed by Simon Fraser.
Calling .get() on a WeakRef which is nullptr will trigger a
debug assertion.
We proceeded to store the result in a RefPtr and then check
that result for nullptr, so effectively this change is a no-op
but it relied on UB as it would effectively assume:
if (RefPtr r = &(*(nullptr)))
evaluated to false, but that is UB in C++
* Source/WebKit/WebProcess/Model/WebModelPlayer.mm:
(WebKit::WebModelPlayer::load):
(WebKit::WebModelPlayer::sizeDidChange):
(WebKit::WebModelPlayer::scheduleUpdateIfNeeded):
(WebKit::WebModelPlayer::updateScreenHeadroomFromPage):
Canonical link: https://commits.webkit.org/315710@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
