Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ce73b886a6e182bd1f9acaf0dda830e41172d804
https://github.com/WebKit/WebKit/commit/ce73b886a6e182bd1f9acaf0dda830e41172d804
Author: Alex Christensen <[email protected]>
Date: 2026-06-24 (Wed, 24 Jun 2026)
Changed paths:
M Source/ThirdParty/libwebrtc/CMakeLists.txt
M Source/WebCore/PlatformCocoa.cmake
Log Message:
-----------
Fix NSInvalidArgumentException when running cmake MiniBrowser on sites with
media
https://bugs.webkit.org/show_bug.cgi?id=317680
rdar://180438345
Reviewed by Pascoe.
When opening pages with media with cmake minibrowser on macOS, I get crashes
like this:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException',
reason: '-[WK_RTCVideoCodecInfo nativeSdpVideoFormat]: unrecognized selector
sent to instance
This is because we weren't even compiling nativeSdpVideoFormat. As suggested
by Simon Lewis,
we put the Private.mm files in their own library so that they are actually
loaded by the linker,
which otherwise continues to ignore them.
* Source/ThirdParty/libwebrtc/CMakeLists.txt:
* Source/WebCore/PlatformCocoa.cmake:
Canonical link: https://commits.webkit.org/315765@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
