Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e923dba3a033f32e09809aa64920df2f86bbdaf4
https://github.com/WebKit/WebKit/commit/e923dba3a033f32e09809aa64920df2f86bbdaf4
Author: Jer Noble <[email protected]>
Date: 2026-06-24 (Wed, 24 Jun 2026)
Changed paths:
M Source/WebCore/DerivedSources-input.xcfilelist
M Source/WebCore/DerivedSources.make
A Source/WebCore/Modules/modern-media-controls/media/CNNCaptionQuirk.js
M Source/WebCore/PlatformCocoa.cmake
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/dom/DocumentMediaElement.cpp
M Source/WebCore/dom/DocumentMediaElement.h
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
M Source/WebCore/page/QuirksData.h
M Source/WebCore/rendering/RenderTheme.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.h
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
Log Message:
-----------
[iOS] CNN.com subtitles don't work in native fullscreen
rdar://175298523
https://bugs.webkit.org/show_bug.cgi?id=316460
Reviewed by Jean-Yves Avenard.
Add a Quirk to CNN.com which "mirrors" the captions provided in the DOM
into VTTCues and a synthetic text track.
* Source/WebCore/DerivedSources-input.xcfilelist:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/Modules/modern-media-controls/media/CNNCaptionQuirk.js: Added.
(CaptionMirror):
(CaptionMirror.prototype.invalidate):
(CaptionMirror.prototype._findPlayerRoot):
(CaptionMirror.prototype._syncCues):
(CaptionMirror.prototype._attachOverlayObserver):
(CaptionMirror.prototype._attachCaptionObserver):
(CaptionMirror.prototype._handlePresentationModeChanged):
(window.setupCaptionMirroring):
* Source/WebCore/PlatformCocoa.cmake:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/dom/DocumentMediaElement.cpp:
(WebCore::DocumentMediaElement::setupAndCallCNNQuirkJS):
(WebCore::DocumentMediaElement::ensureCNNQuirkScript):
* Source/WebCore/dom/DocumentMediaElement.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::postConnectionSteps):
* Source/WebCore/page/Quirks.cpp:
* Source/WebCore/page/Quirks.h:
* Source/WebCore/page/QuirksData.h:
* Source/WebCore/rendering/RenderTheme.h:
(WebCore::RenderTheme::cnnQuirkScript):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.h:
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::cnnQuirkScript):
Canonical link: https://commits.webkit.org/315789@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
