Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 48e92e82ebc073d528b212cef33c8504eb689cfc
https://github.com/WebKit/WebKit/commit/48e92e82ebc073d528b212cef33c8504eb689cfc
Author: Charlie Wolfe <[email protected]>
Date: 2026-06-24 (Wed, 24 Jun 2026)
Changed paths:
M Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm
M Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
Log Message:
-----------
CoreIPCNSURLCredential::toID inserts the attributes dictionary as its own
value
https://bugs.webkit.org/show_bug.cgi?id=317456
rdar://180075625
Reviewed by Sihui Liu.
The reconstruction loop computed `value` via switchOn, then discarded it and
inserted
`attributes.get()` as the value for the key. This produced a self-referential
dictionary mapping
every attribute key to the dictionary itself, so the real decoded attribute
values were lost on the
receiving side. Insert value.get().
Test: Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm
* Source/WebKit/Shared/Cocoa/CoreIPCNSURLCredential.mm:
(WebKit::CoreIPCNSURLCredential::toID const):
* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(TEST(IPCSerialization, NSURLCredentialAttributesToID)):
Canonical link: https://commits.webkit.org/315793@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
