Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d0b94cb5b4a4b6e623bd13d71d666de126d9897f
https://github.com/WebKit/WebKit/commit/d0b94cb5b4a4b6e623bd13d71d666de126d9897f
Author: Fady Farag <[email protected]>
Date: 2026-06-25 (Thu, 25 Jun 2026)
Changed paths:
A Source/WebKit/Platform/EditingRangeClamping.cpp
M Source/WebKit/Platform/Sources.txt
M Source/WebKit/Shared/EditingRange.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
Make `EditingRange::clampedFirstLineRange` defined out-of-line and move into
a `.cpp` file
https://bugs.webkit.org/show_bug.cgi?id=317718
rdar://180472627
Reviewed by Chris Dumez.
Initially, EditingRange::clampedFirstLineRange failed to link out-of-line when
used from the IPC API tests even when using WK_EXPORT. The reason is that
TestIPC
links against libWebKitPlatform.a, not WebKit.framework. So, a symbol in the
framework dylib is unreachable from the test regardless of export macros. This
defines the symbol out-of-line in a new translation unit such that it builds
into
libWebKitPlatform.a so the symbol resolves directly.
* Source/WebKit/Platform/EditingRangeClamping.cpp: Added.
(WebKit::EditingRange::clampedFirstLineRange):
* Source/WebKit/Platform/Sources.txt:
* Source/WebKit/Shared/EditingRange.h:
(WebKit::EditingRange::clampedFirstLineRange): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/315816@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
