Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: adf29ea7ecf4e77e125f79d021fd12033fd023fd
https://github.com/WebKit/WebKit/commit/adf29ea7ecf4e77e125f79d021fd12033fd023fd
Author: Nikolas Zimmermann <[email protected]>
Date: 2026-06-25 (Thu, 25 Jun 2026)
Changed paths:
M Source/JavaScriptCore/CMakeLists.txt
M Source/WTF/wtf/CMakeLists.txt
M Source/WebCore/CMakeLists.txt
M Source/WebCore/PAL/pal/CMakeLists.txt
M Source/WebKit/CMakeLists.txt
M Source/WebKitLegacy/CMakeLists.txt
M Source/bmalloc/CMakeLists.txt
M Source/cmake/WebKitMacros.cmake
Log Message:
-----------
[CMake] Prune stale staged headers so renamed headers don't break module
builds
https://bugs.webkit.org/show_bug.cgi?id=317843
Reviewed by Adrian Taylor.
When staging public headers we only ever copy or symlink files, never
remove them. So renaming or deleting a header left the old copy behind in
the framework Headers dir. With Clang modules that leftover file gets
picked up alongside the new one, causing duplicate definitions and build
failures - for example the SaturatedArithmetic.h -> SaturatingArithmetic.h
rename broke the wtf module.
Move the cleanup that WEBKIT_SYMLINK_FILES already did into a shared
WEBKIT_PRUNE_STALE_DESTINATION helper, and add a PRUNE_STALE option to both
WEBKIT_COPY_FILES and WEBKIT_SYMLINK_FILES. Turn it on for the framework
header stagers, which own their destination. It stays optional because some
copy steps share a destination, where pruning would delete another step's
output.
* Source/JavaScriptCore/CMakeLists.txt:
* Source/WTF/wtf/CMakeLists.txt:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/PAL/pal/CMakeLists.txt:
* Source/WebKit/CMakeLists.txt:
* Source/WebKitLegacy/CMakeLists.txt:
* Source/bmalloc/CMakeLists.txt:
* Source/cmake/WebKitMacros.cmake:
Canonical link: https://commits.webkit.org/315823@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
