Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f18d94d48d0d726f6f79a95f6273271fdd84654e
https://github.com/WebKit/WebKit/commit/f18d94d48d0d726f6f79a95f6273271fdd84654e
Author: Sammy Gill <[email protected]>
Date: 2026-06-25 (Thu, 25 Jun 2026)
Changed paths:
M Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.cpp
M Source/WebCore/layout/formattingContexts/grid/GridLayoutUtils.cpp
M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
M
Source/WebCore/layout/integration/LayoutIntegrationFormattingContextLayout.cpp
M
Source/WebCore/layout/integration/LayoutIntegrationFormattingContextLayout.h
M Source/WebCore/layout/integration/LayoutIntegrationUtils.cpp
M Source/WebCore/layout/integration/LayoutIntegrationUtils.h
Log Message:
-----------
[Cleanup] Stray references to preferred widths in LFC code
https://bugs.webkit.org/show_bug.cgi?id=317868
rdar://180651355
Reviewed by Alan Baradlay.
The modern layout (LFC) code still referred to a box's min/max-content
contribution as its "preferred" width, even though it computes exactly that
contribution (per css-sizing-3 §4.3). Bring it in line with the rendering-side
cleanup (314036@main, bug 315891):
- LogicalWidthType::Preferred{Maximum,Minimum} -> {Max,Min}ContentContribution.
Max/MinContent stays as-is — those are the content *size*
(computeIntrinsicLogicalWidths), not the contribution.
- IntegrationUtils::preferred{Min,Max}Width ->
{min,max}ContentLogicalWidthContribution, matching the
RenderBox::{min,max}ContentLogicalWidthContribution they forward to, plus
the grid callers in GridLayoutUtils.
- Reword the comments in block/inline formatting contexts describing the
intrinsic width contribution computation.
The CSS 2.2 table-layout / shrink-to-fit / aspect-ratio "preferred" spec terms
are intentionally left unchanged.
No behavior change.
Canonical link: https://commits.webkit.org/315845@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
