Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 828871706d95b1ff892567e281a37f0d9a278f21
https://github.com/WebKit/WebKit/commit/828871706d95b1ff892567e281a37f0d9a278f21
Author: Marcos Caceres <[email protected]>
Date: 2026-06-26 (Fri, 26 Jun 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/digital-credentials/get.https-expected.txt
M Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp
M Source/WebCore/Modules/identity/CredentialRequestCoordinator.h
Log Message:
-----------
Digital Credentials: CredentialRequestCoordinator should transition to
Requesting state before setting promise
https://bugs.webkit.org/show_bug.cgi?id=309625
rdar://172236892
Reviewed by Anne van Kesteren.
Maintain the invariant that the interaction state is 'idle' iff no
current promise is set. Set the state and promise as an atomic pair at
the top of prepareCredentialRequests (after the idle check), and route
error paths through a new rejectTheCredentialRequestWith helper that
implements §6.5 "Reject the credential request with":
https://w3c-fedid.github.io/digital-credentials/#dfn-reject-the-credential-request-with
Covered by existing digital-credentials tests.
* Source/WebCore/Modules/identity/CredentialRequestCoordinator.cpp:
(WebCore::CredentialRequestCoordinator::setCurrentPromise):
(WebCore::CredentialRequestCoordinator::prepareCredentialRequests):
(WebCore::CredentialRequestCoordinator::initiateTheCredentialRequest):
(WebCore::CredentialRequestCoordinator::rejectTheCredentialRequestWith):
(WebCore::CredentialRequestCoordinator::abortTheCredentialRequest):
* Source/WebCore/Modules/identity/CredentialRequestCoordinator.h:
Canonical link: https://commits.webkit.org/315893@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
