Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c19fd54ed774fe9e4cfce7c193448e44a470b49e
https://github.com/WebKit/WebKit/commit/c19fd54ed774fe9e4cfce7c193448e44a470b49e
Author: Qianlang Chen <[email protected]>
Date: 2026-06-26 (Fri, 26 Jun 2026)
Changed paths:
M Tools/MiniBrowser/mac/CMakeLists.txt
Log Message:
-----------
[CMake] Minibrowser crashes on start in [BrowserAppDelegate targetURL]
https://bugs.webkit.org/show_bug.cgi?id=317896
Reviewed by Geoffrey Garen.
The Xcode build of MiniBrowser enables ARC via Base.xcconfig
(CLANG_ENABLE_OBJC_ARC = YES), but the CMake port was compiling the same
sources without ARC. The sources are written assuming ARC retain
semantics: in AppDelegate.m, `static NSString *sTargetURL = [args
objectAtIndex:...]`
relies on __strong's auto-retain. Without ARC, sTargetURL ends up
dangling and crashes -[BrowserAppDelegate targetURL] with EXC_BAD_ACCESS
in objc_msgSend on first window open. (The crash is currently masked by
a separate startup hang and surfaces once that's resolved.)
Pass -fobjc-arc to the MiniBrowser target so the CMake build matches the
Xcode port's ARC setting.
No new tests; build system changes only.
* Tools/MiniBrowser/mac/CMakeLists.txt:
Canonical link: https://commits.webkit.org/315900@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
