Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6b5f79b75b8f8ba1a3a5db9bef8b7b31c0804c74
https://github.com/WebKit/WebKit/commit/6b5f79b75b8f8ba1a3a5db9bef8b7b31c0804c74
Author: Tyler Wilcock <[email protected]>
Date: 2026-06-26 (Fri, 26 Jun 2026)
Changed paths:
M Source/WebKit/Shared/Cocoa/AccessibilityPreferences.mm
M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm
A Source/WebKit/Shared/Cocoa/LibAccessibilitySoftLink.h
A Source/WebKit/Shared/Cocoa/LibAccessibilitySoftLink.mm
M Source/WebKit/SourcesCocoa.txt
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
AX: Move libAccessibility soft-linking into a shared
LibAccessibilitySoftLink.{h,mm}
https://bugs.webkit.org/show_bug.cgi?id=317797
rdar://180565005
Reviewed by Andres Gonzalez and Dominic Mazzoni.
AccessibilityPreferences.mm declared the libAccessibility library soft-link with
SOFT_LINK_LIBRARY_OPTIONAL(), and AuxiliaryProcessCocoa.mm relied on that
declaration to resolve libAccessibilityLibrary() for its own
SOFT_LINK_OPTIONAL(libAccessibility, _AXSUpdateWebAccessibilitySettings, ...).
SOFT_LINK_LIBRARY_OPTIONAL() and SOFT_LINK_OPTIONAL() generate static,
file-local
symbols, so this only compiled because both files happened to land in the same
unified-sources translation unit. Adding or reordering files in Shared/Cocoa
would eventually break the build.
Move both soft-links into a dedicated LibAccessibilitySoftLink.{h,mm} that uses
the SOFT_LINK_LIBRARY_FOR_HEADER/_FOR_SOURCE and
SOFT_LINK_FUNCTION_MAY_FAIL_FOR_HEADER/_FOR_SOURCE macros, which emit extern,
namespaced symbols defined once and intended for sharing across source files.
* Source/WebKit/Shared/Cocoa/AccessibilityPreferences.mm:
(AXPreferenceHelpers::imageAnimationEnabled):
* Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::handleAXPreferenceChange):
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/315903@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
