Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 444ef0db08a62d30713aa74253f4c96c0342118c
https://github.com/WebKit/WebKit/commit/444ef0db08a62d30713aa74253f4c96c0342118c
Author: Ryan Haddad <[email protected]>
Date: 2026-06-26 (Fri, 26 Jun 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
Log Message:
-----------
EWS counts a build as a "failure" if its log contains "error:" even if it's
not actually an error
https://bugs.webkit.org/show_bug.cgi?id=317550
rdar://180248076
Reviewed by Richard Robinson and Aakash Jain.
Remove the temporary "build_failed" silent-failure workaround from CompileWebKit
(originally added in 288180@main and adjusted in 288231@main). It marked the
compile step
as FAILURE whenever anything was delivered to errorReceived, which meant an
otherwise-successful
build whose log merely contained the string "error" was forced to fail. The
underlying
silent-failure issue that motivated the workaround has since been resolved, so
the compile
result is once again driven by the actual command result.
* Tools/CISupport/ews-build/steps.py:
(CompileWebKit.__init__):
(CompileWebKit.errorReceived):
(CompileWebKit.getResultSummary):
Canonical link: https://commits.webkit.org/315935@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
