Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9bb8e303b0b4e30586b3bc6229df8342f29f32b2
https://github.com/WebKit/WebKit/commit/9bb8e303b0b4e30586b3bc6229df8342f29f32b2
Author: Ahmad Saleem <[email protected]>
Date: 2026-06-29 (Mon, 29 Jun 2026)
Changed paths:
M Source/WebCore/page/Quirks.cpp
Log Message:
-----------
Remove redundant duplicate checks in Quirks embedded YouTube storage access
branch
https://bugs.webkit.org/show_bug.cgi?id=318095
rdar://180889276
Reviewed by Chris Dumez.
The embedded YouTube case in Quirks::triggerOptionalStorageAccessQuirk()
had two redundant checks:
- The class-name test was "X || X": it called
element.hasClassName("ytp-watch-later-icon") twice, OR'd together.
- It re-tested ResourceLoadObserver::hasHadUserInteraction(youTubeDomain)
inside the block, even though the enclosing if already requires that
same condition to be true.
Because both the inner and outer paths return ShouldNotCancelEvent, the
whole branch collapses to: request document storage access when the
element has the watch-later icon class, then return ShouldNotCancelEvent.
Simplified accordingly. No behavior change.
* Source/WebCore/page/Quirks.cpp:
Canonical link: https://commits.webkit.org/316002@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
