Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: bcc89c676083459b13d02ccefc82a665613ae626
https://github.com/WebKit/WebKit/commit/bcc89c676083459b13d02ccefc82a665613ae626
Author: Ahmad Saleem <[email protected]>
Date: 2026-06-29 (Mon, 29 Jun 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/multiline-last-baseline-item-count-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/multiline-last-baseline-item-count-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/multiline-last-baseline-item-count.html
M Source/WebCore/rendering/RenderFlexibleBox.cpp
Log Message:
-----------
Fix typo in RenderFlexibleBox::performFlexLayout(): last-line item count read
from first line
https://bugs.webkit.org/show_bug.cgi?id=318069
rdar://180869111
Reviewed by Alan Baradlay.
lastLineItemsCountInOriginalOrder was initialized from lineStates.first()
instead of lineStates.last() — a copy/paste typo from the line above. This
patch fixes it.
When the first and last lines of a wrapping flex container have a different
number of items, the count used to locate the container's last baseline was
wrong, so the baseline was taken from a baseline-aligned item on the first
line instead of an item on the last line. Added a reftest covering this case
(first line: two items, last line: one item); it failed before this change
and matches Chrome and Firefox now.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::performFlexLayout):
*
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/multiline-last-baseline-item-count-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/multiline-last-baseline-item-count-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/multiline-last-baseline-item-count.html:
Added.
Canonical link: https://commits.webkit.org/316027@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
