Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cc76b52970313c929ffe2570f568b52e686ea50a
https://github.com/WebKit/WebKit/commit/cc76b52970313c929ffe2570f568b52e686ea50a
Author: Richard Robinson <[email protected]>
Date: 2026-06-29 (Mon, 29 Jun 2026)
Changed paths:
M Source/WebCore/platform/RectEdges.h
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Modules/Internal/module.modulemap
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.h
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm
A Source/WebKit/UIProcess/mac/WKAppKitGestureController.swift
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
[AppKit Gestures] Adopt the
`NSPanGestureRecognizer._shouldRecognize(forDelta:)` SPI for
WKPanGestureRecognizer
https://bugs.webkit.org/show_bug.cgi?id=318040
rdar://180824633
Reviewed by Abrar Rahman Protyasha.
Also take the opportunity to convert `WKPanGestureRecognizer` to Swift.
* Source/WebCore/platform/RectEdges.h:
Annotate some functions to specify the lifetimes of their returned value.
* Source/WebKit/Modules/Internal/module.modulemap:
Add WKAppKitGestureController to the module so Swift can see it
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.h:
Expose some methods/properties so that the Objective-C and Swift sides of
WKAppKitGestureController can interop.
These will be removed as more of the file becomes Swift.
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm:
(-[WKAppKitGestureController webView]):
(-[WKAppKitGestureController panGestureRecognizer]):
(-[WKAppKitGestureController setPanGestureRecognizer:]):
(-[WKPanGestureRecognizer initWithPage:target:action:]): Deleted.
(-[WKPanGestureRecognizer shouldRecognizeForDelta:]): Deleted.
(-[WKAppKitGestureController setUpPanGestureRecognizer]): Deleted.
Remove the Obj-C implementation
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.swift: Added.
(WKPanGestureRecognizer.webView):
(WKPanGestureRecognizer._shouldRecognize(forDelta:)):
(WKAppKitGestureController.setUpPanGestureRecognizer):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Implementation in Swift, and use the
`NSPanGestureRecognizer._shouldRecognize(forDelta:)` SPI.
Canonical link: https://commits.webkit.org/316070@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications