Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b394fb2309d4f50f9324285c064f43c0ea36bf9d
https://github.com/WebKit/WebKit/commit/b394fb2309d4f50f9324285c064f43c0ea36bf9d
Author: Alan Baradlay <[email protected]>
Date: 2026-06-29 (Mon, 29 Jun 2026)
Changed paths:
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/Position.cpp
M Source/WebCore/editing/CompositeEditCommand.cpp
M Source/WebCore/editing/TextIterator.cpp
M Source/WebCore/html/HTMLTableColElement.cpp
M Source/WebCore/html/HTMLTextFormControlElement.cpp
M Source/WebCore/html/shadow/SliderThumbElement.cpp
M Source/WebCore/html/shadow/SpinButtonElement.cpp
M Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/ios/FrameIOS.mm
M Source/WebCore/rendering/AttachmentLayout.mm
M Source/WebCore/rendering/BaselineAlignment.cpp
M Source/WebCore/rendering/CaretRectComputation.cpp
M Source/WebCore/rendering/GridMasonryLayout.cpp
M Source/WebCore/rendering/LegacyInlineBox.cpp
M Source/WebCore/rendering/OutlinePainter.cpp
M Source/WebCore/rendering/PositionedLayoutConstraints.cpp
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderBlock.h
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxInlines.h
M Source/WebCore/rendering/RenderButton.cpp
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderFileUploadControl.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFragmentedFlow.cpp
M Source/WebCore/rendering/RenderFrameSet.cpp
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderListBox.cpp
M Source/WebCore/rendering/RenderListBox.h
M Source/WebCore/rendering/RenderListMarker.cpp
M Source/WebCore/rendering/RenderMarquee.cpp
M Source/WebCore/rendering/RenderMultiColumnSet.cpp
M Source/WebCore/rendering/RenderReplica.cpp
M Source/WebCore/rendering/RenderScrollbar.cpp
M Source/WebCore/rendering/RenderSearchField.cpp
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/RenderTableSection.cpp
M Source/WebCore/rendering/RenderTheme.cpp
M Source/WebCore/rendering/RenderTreeAsText.cpp
M Source/WebCore/rendering/RenderVTTCue.cpp
M Source/WebCore/rendering/RenderView.cpp
M Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm
M Source/WebCore/rendering/ios/RenderThemeIOS.mm
M Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp
M Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp
M Source/WebKitLegacy/mac/DOM/DOMHTML.mm
M Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm
M Source/WebKitLegacy/mac/WebView/WebFrame.mm
Log Message:
-----------
[cleanup] Rename RenderBox::width()/height() to
borderBoxWidth()/borderBoxHeight()
https://bugs.webkit.org/show_bug.cgi?id=318037
<rdar://problem/180943529>
Reviewed by Antti Koivisto.
RenderBox::width()/height() return the border box width/height, but the bare
names don't say so. They were the unqualified odd ones out next to
contentBoxWidth()/paddingBoxWidth()/clientWidth(), and now next to
borderBoxSize(). Name them for what they are.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeIsIgnored const):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::updateMainArticleElementAfterLayout):
* Source/WebCore/dom/Position.cpp:
(WebCore::endsOfNodeAreVisuallyDistinctPositions):
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::shouldEmitExtraNewlineForNode):
(WebCore::TextIterator::shouldRepresentNodeOffsetZero):
* Source/WebCore/html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::attributeChanged):
* Source/WebCore/html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange):
* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout):
(WebCore::SliderThumbElement::setPositionFromPoint):
* Source/WebCore/html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::defaultEventHandler):
* Source/WebCore/layout/integration/LayoutIntegrationBoxGeometryUpdater.cpp:
(WebCore::LayoutIntegration::baselineForBox):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::firstInlineBoxRect const):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::TreeBuilder::buildLayoutTree):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::fixedContainerEdges const):
* Source/WebCore/page/ios/FrameIOS.mm:
(WebCore::LocalFrame::preferredHeight const):
* Source/WebCore/rendering/AttachmentLayout.mm:
(WebCore::AttachmentLayout::AttachmentLayout):
* Source/WebCore/rendering/BaselineAlignment.cpp:
(WebCore::BaselineAlignmentState::synthesizedBaseline):
* Source/WebCore/rendering/CaretRectComputation.cpp:
(WebCore::computeCaretRectForBox):
* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::masonryAxisMarginBoxForItem):
* Source/WebCore/rendering/LegacyInlineBox.cpp:
(WebCore::LegacyInlineBox::locationIncludingFlipping const):
* Source/WebCore/rendering/OutlinePainter.cpp:
(WebCore::OutlinePainter::collectFocusRingRectsForBlock):
* Source/WebCore/rendering/PositionedLayoutConstraints.cpp:
(WebCore::PositionedLayoutConstraints::captureGridArea):
* Source/WebCore/rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChild):
(WebCore::clipOutOutOfFlowBoxes):
(WebCore::RenderBlock::selectionGaps):
(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
* Source/WebCore/rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalWidthForChild const):
(WebCore::RenderBlock::logicalHeightForChild const):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::clipOutFloatingBoxes):
(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::flipFloatForWritingModeForChild const):
(WebCore::RenderBlockFlow::findClosestTextAtAbsolutePoint):
(WebCore::RenderBlockFlow::adjustComputedFontSizes):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::absoluteQuads const):
(WebCore::RenderBox::paddingBoxRect const):
(WebCore::isCandidateForOpaquenessTest):
(WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect const):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::clipRect const):
(WebCore::RenderBox::containingBlockRangeForPositioned const):
(WebCore::RenderBox::convertRectToParentWritingMode const):
(WebCore::RenderBox::flipForWritingModeForChild const):
(WebCore::RenderBox::flipForWritingMode const):
* Source/WebCore/rendering/RenderBox.h:
(WebCore::RenderBox::borderBoxWidth const):
(WebCore::RenderBox::borderBoxHeight const):
(WebCore::RenderBox::tryLayoutDoingOutOfFlowMovementOnly):
(WebCore::RenderBox::width const): Deleted.
(WebCore::RenderBox::height const): Deleted.
* Source/WebCore/rendering/RenderBoxInlines.h:
(WebCore::RenderBox::marginBoxLogicalHeight const):
(WebCore::RenderBox::logicalHeight const):
(WebCore::RenderBox::logicalWidth const):
(WebCore::RenderBox::paddingBoxHeight const):
(WebCore::RenderBox::paddingBoxWidth const):
(WebCore::RenderBox::paddingBoxRectIncludingScrollbar const):
(WebCore::RenderBox::contentBoxRect const):
* Source/WebCore/rendering/RenderButton.cpp:
(WebCore::RenderButton::controlClipRect const):
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):
* Source/WebCore/rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintControl):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::crossAxisExtentForFlexItem const):
(WebCore::RenderFlexibleBox::performFlexLayout):
* Source/WebCore/rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::offsetFromLogicalTopOfFirstFragment const):
* Source/WebCore/rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::paintColumnBorder):
(WebCore::RenderFrameSet::paintRowBorder):
(WebCore::RenderFrameSet::paint):
(WebCore::RenderFrameSet::layout):
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridAreaRangeForOutOfFlow const):
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::collectSelectionGeometries):
* Source/WebCore/rendering/RenderLayer.cpp:
(WebCore::RenderLayer::minimumSizeForResizing const):
(WebCore::RenderLayer::resize):
* Source/WebCore/rendering/RenderListBox.cpp:
(WebCore::RenderListBox::listIndexAtOffset const):
(WebCore::RenderListBox::rectForScrollbar const):
* Source/WebCore/rendering/RenderListBox.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::imageChanged):
(WebCore::RenderListMarker::relativeMarkerRect):
* Source/WebCore/rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::computePosition):
* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::paintColumnRules):
* Source/WebCore/rendering/RenderReplica.cpp:
(WebCore::RenderReplica::computeIntrinsicLogicalWidthContributions):
* Source/WebCore/rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::RenderScrollbar):
(WebCore::RenderScrollbar::updateScrollbarParts):
(WebCore::RenderScrollbar::minimumThumbLength const):
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::clientInsetLeft const):
(WebCore::RenderSearchField::clientInsetRight const):
(WebCore::RenderSearchField::clientPaddingRight const):
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::addOverflowFromInFlowChildren):
(WebCore::RenderTable::overflowClipRect const):
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::localRectsForRepaint const):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
* Source/WebCore/rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::offsetLeftForRowGroupBorder):
(WebCore::RenderTableSection::offsetTopForRowGroupBorder):
(WebCore::RenderTableSection::verticalRowGroupBorderHeight):
(WebCore::RenderTableSection::horizontalRowGroupBorderWidth):
* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::baselinePosition const):
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::externalRepresentation):
* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::initializeLayoutParameters):
(WebCore::RenderVTTCue::shouldSwitchDirection const):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::layout):
(WebCore::RenderView::paintBoxDecorations):
* Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::adjustedPaintRect const):
(WebCore::shapeForButton):
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustRoundBorderRadius):
* Source/WebCore/rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::layoutItems):
* Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::makeShapeForShapeOutside):
* Source/WebKitLegacy/mac/DOM/DOMHTML.mm:
(-[DOMHTMLElement absolutePosition::::]):
* Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm:
(-[DOMHTMLElement structuralComplexityContribution]):
* Source/WebKitLegacy/mac/WebView/WebFrame.mm:
(-[WebFrame renderedSizeOfNode:constrainedToWidth:]):
Canonical link: https://commits.webkit.org/316085@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
