Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d59a367e9307051c90ad8dbccbaa8532ceeb1df1
https://github.com/WebKit/WebKit/commit/d59a367e9307051c90ad8dbccbaa8532ceeb1df1
Author: Sammy Gill <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-min-height-overrides-fixed-height-001-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-min-height-overrides-fixed-height-001.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-min-width-overrides-fixed-width-001-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-item-min-width-overrides-fixed-width-001.html
M Source/WebCore/layout/formattingContexts/grid/GridItemSizingFunctions.cpp
M Source/WebCore/layout/formattingContexts/grid/GridLayout.cpp
M Source/WebCore/layout/formattingContexts/grid/GridLayoutUtils.cpp
M Source/WebCore/layout/formattingContexts/grid/GridLayoutUtils.h
Log Message:
-----------
[GFC] Min sizes are not always respected.
https://bugs.webkit.org/show_bug.cgi?id=318241
rdar://problem/181047884
Reviewed by Alan Baradlay.
We were not always respecting the min/max size of a grid item because it
was mixed into the logic that computing the preferred size. We can fix
this instead by moving this logic into their own dedicated functions and
then use them to restrict the preferred size according to these values
once everything has been computed.
Renaming these functions should also make it much more clear about what
is being computed.
The "used" size functions now just compute the preferred size (i.e.
width/height properties) and the minimum and maximum size computations
are in their own dedicated functions.
The used size functions now just call into the three sets of functions
for the axis and then return the preferred size constrained by the min
and max sizes. It should hopefully now be much clearer what the used
size functions compute given how short they are and the newly named
functions they call into.
Canonical link: https://commits.webkit.org/316284@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
