Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ebf470598457240abd83094a80f79411ef1c9115
https://github.com/WebKit/WebKit/commit/ebf470598457240abd83094a80f79411ef1c9115
Author: Alan Baradlay <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/inspector/InspectorOverlay.cpp
M Source/WebCore/layout/Verification.cpp
M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/rendering/RenderBlockFlow.cpp
M Source/WebCore/rendering/RenderBox.cpp
M Source/WebCore/rendering/RenderBox.h
M Source/WebCore/rendering/RenderBoxInlines.h
M Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
M Source/WebCore/rendering/RenderElement.cpp
M Source/WebCore/rendering/RenderFlexibleBox.cpp
M Source/WebCore/rendering/RenderFlexibleBox.h
M Source/WebCore/rendering/RenderGrid.cpp
M Source/WebCore/rendering/RenderLayer.cpp
M Source/WebCore/rendering/RenderLayerBacking.cpp
M Source/WebCore/rendering/RenderLayerScrollableArea.cpp
M Source/WebCore/rendering/RenderLayoutState.h
M Source/WebCore/rendering/RenderMeter.cpp
M Source/WebCore/rendering/RenderMultiColumnSet.cpp
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderProgress.cpp
M Source/WebCore/rendering/RenderReplica.cpp
M Source/WebCore/rendering/RenderScrollbar.cpp
M Source/WebCore/rendering/RenderTable.cpp
M Source/WebCore/rendering/RenderTableCell.cpp
M Source/WebCore/rendering/RenderTableSection.cpp
M Source/WebCore/rendering/RenderTextControlSingleLine.cpp
M Source/WebCore/rendering/RenderTreeAsText.cpp
M Source/WebCore/rendering/mathml/RenderMathMLMath.cpp
M Source/WebCore/rendering/mathml/RenderMathMLRow.cpp
M Source/WebCore/rendering/svg/RenderSVGText.cpp
M Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp
Log Message:
-----------
[cleanup] Rename RenderBox::frameRect()/setFrameRect() to
borderBoxRectInContainer()/setBorderBoxRectInContainer()
https://bugs.webkit.org/show_bug.cgi?id=318048
<rdar://problem/181125416>
Reviewed by Antti Koivisto.
m_frameRect and its frameRect()/setFrameRect() accessors hold the border box
positioned in the container's coordinate space, but "frame" was vague and
collided
with Frame/LocalFrame. Rename them to m_borderBoxRectInContainer /
borderBoxRectInContainer() / setBorderBoxRectInContainer(), naming the thing
for what
it is and pairing directly with the existing borderBoxRect() (the same rect in
the
renderer's own coordinates, { 0, 0, size }) -- the only difference is the
coordinate
space. "container" matches RenderBox.h's own description of the location
("relative to
your container") and the mapLocalToContainer/offsetFromContainer vocabulary.
Also fixes the stale "frame rect" comments left behind and renames the flex
repaint-snapshot helpers (ChildFrameRects/FlexItemFrameRects and their append*
functions) to ...BorderBoxRects to match. No behavior change.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(AccessibilityRenderObject::localRect):
* Source/WebCore/inspector/InspectorOverlay.cpp:
(InspectorOverlay::buildFlexOverlay):
* Source/WebCore/layout/Verification.cpp:
(outputMismatchingBlockBoxInformationIfNeeded):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(LineLayout::updateRenderTreePositions):
* Source/WebCore/page/LocalFrameView.cpp:
(LocalFrameView::visibleRectOfChild):
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(RenderBlockFlow::layoutBlockChild):
(RenderBlockFlow::positionNewFloats):
* Source/WebCore/rendering/RenderBox.cpp:
(RenderBox::repaintDuringLayoutIfMoved):
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxInlines.h:
(RenderBox::logicalSize):
* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(appendChildBorderBoxRects):
(repaintChildrenDuringLayoutIfMoved):
(RenderDeprecatedFlexibleBox::layoutBlock):
* Source/WebCore/rendering/RenderElement.cpp:
(RenderElement::getTrailingCorner):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(RenderFlexibleBox::appendFlexItemBorderBoxRects):
(RenderFlexibleBox::repaintFlexItemsDuringLayoutIfMoved):
(RenderFlexibleBox::layoutBlock):
* Source/WebCore/rendering/RenderFlexibleBox.h:
* Source/WebCore/rendering/RenderGrid.cpp:
(RenderGrid::layoutGridItems):
* Source/WebCore/rendering/RenderLayer.cpp:
(computeLayerPositionAndIntegralSize):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(RenderLayerBacking::RenderLayerBacking):
* Source/WebCore/rendering/RenderLayerScrollableArea.cpp:
(RenderLayerScrollableArea::positionOverflowControls):
* Source/WebCore/rendering/RenderLayoutState.h:
* Source/WebCore/rendering/RenderMeter.cpp:
(RenderMeter::updateLogicalWidth):
(RenderMeter::computeLogicalHeight):
* Source/WebCore/rendering/RenderMultiColumnSet.cpp:
(RenderMultiColumnSet::collectLayerFragments):
* Source/WebCore/rendering/RenderObject.cpp:
(RenderObject::outputRenderObject):
* Source/WebCore/rendering/RenderProgress.cpp:
(RenderProgress::updateFromElement):
* Source/WebCore/rendering/RenderReplica.cpp:
(RenderReplica::layout):
* Source/WebCore/rendering/RenderScrollbar.cpp:
(RenderScrollbar::buttonRect):
* Source/WebCore/rendering/RenderTable.cpp:
(RenderTable::layoutCaption):
* Source/WebCore/rendering/RenderTableCell.cpp:
(backgroundRectForRow):
* Source/WebCore/rendering/RenderTableSection.cpp:
(RenderTableSection::layoutRows):
(RenderTableSection::paintObject):
* Source/WebCore/rendering/RenderTextControlSingleLine.cpp:
(RenderTextControlSingleLine::controlClipRect):
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(RenderTreeAsText::writeRenderObject):
* Source/WebCore/rendering/mathml/RenderMathMLMath.cpp:
(RenderMathMLMath::centerChildren):
* Source/WebCore/rendering/mathml/RenderMathMLRow.cpp:
(RenderMathMLRow::layoutRowItems):
* Source/WebCore/rendering/svg/RenderSVGText.cpp:
(RenderSVGText::updatePositionAndOverflow):
* Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp:
(writePositionAndStyle):
Canonical link: https://commits.webkit.org/316286@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
