Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: aeebf22258151fda6a4262d15107025125332642
https://github.com/WebKit/WebKit/commit/aeebf22258151fda6a4262d15107025125332642
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-01 (Wed, 01 Jul 2026)
Changed paths:
A
LayoutTests/svg/repaint/marker-markerUnits-dynamic-update-repaint-expected.txt
A LayoutTests/svg/repaint/marker-markerUnits-dynamic-update-repaint.html
A LayoutTests/svg/repaint/marker-orient-dynamic-update-repaint-expected.txt
A LayoutTests/svg/repaint/marker-orient-dynamic-update-repaint.html
M Source/WebCore/svg/SVGMarkerElement.cpp
Log Message:
-----------
Dynamic orient/markerUnits changes on SVGMarkerElement don't repaint
referencing element
https://bugs.webkit.org/show_bug.cgi?id=318321
rdar://181106538
Reviewed by Simon Fraser.
SVGMarkerElement::attributeChanged() handled the markerUnitsAttr and
orientAttr cases with an early return; instead of break;, unlike every
other attribute and every peer resource element (pattern/mask/etc.).
The new base value was parsed and stored, but the return skipped the
SVGElement::attributeChanged() call at the end of the switch, so
svgAttributeChanged() -> invalidateMarkerResource() never ran and the
referencing element was not repainted until an unrelated invalidation.
Fix by falling through with break; so both attributes invalidate the
marker resource, matching the other cases.
Tests: svg/repaint/marker-markerUnits-dynamic-update-repaint.html
svg/repaint/marker-orient-dynamic-update-repaint.html
*
LayoutTests/svg/repaint/marker-markerUnits-dynamic-update-repaint-expected.txt:
Added.
* LayoutTests/svg/repaint/marker-markerUnits-dynamic-update-repaint.html: Added.
* LayoutTests/svg/repaint/marker-orient-dynamic-update-repaint-expected.txt:
Added.
* LayoutTests/svg/repaint/marker-orient-dynamic-update-repaint.html: Added.
* Source/WebCore/svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::attributeChanged):
Canonical link: https://commits.webkit.org/316350@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
