Branch: refs/heads/webkitglib/2.52
Home: https://github.com/WebKit/WebKit
Commit: be0658d5f50fc21c1ed500d803e3614ab64dbe93
https://github.com/WebKit/WebKit/commit/be0658d5f50fc21c1ed500d803e3614ab64dbe93
Author: Jer Noble <[email protected]>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
M Source/WebCore/platform/mock/mediasource/MockBox.cpp
Log Message:
-----------
Cherry-pick 4f7a3cfefe44. https://bugs.webkit.org/show_bug.cgi?id=313917
MockSampleBox should not have negative timeScales and duration
rdar://174740124
https://bugs.webkit.org/show_bug.cgi?id=313917
Reviewed by Simon Fraser.
* Source/WebCore/platform/mock/mediasource/MockBox.cpp:
(WebCore::MockInitializationBox::MockInitializationBox):
(WebCore::MockSampleBox::MockSampleBox):
Identifier: 305413.813@safari-7624-branch
Identifier: [email protected]
Canonical link: https://commits.webkit.org/305877.874@webkitglib/2.52
Commit: f09ffa51faf485a4443b6ee919ef0a55e41c87f1
https://github.com/WebKit/WebKit/commit/f09ffa51faf485a4443b6ee919ef0a55e41c87f1
Author: Youenn Fablet <[email protected]>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
A LayoutTests/streams/byob-close-exception-expected.txt
A LayoutTests/streams/byob-close-exception.html
M Source/WebCore/Modules/streams/ReadableByteStreamController.cpp
M Source/WebCore/Modules/streams/ReadableByteStreamController.h
M Source/WebCore/Modules/streams/StreamTeeUtilities.cpp
Log Message:
-----------
Cherry-pick cbd729a317dc. https://bugs.webkit.org/show_bug.cgi?id=313917
[WebCore] unchecked exception return in
ReadableByteStreamController::closeAndRespondToPendingPullIntos and
TeeDefaultReadRequest::runCloseSteps
rdar://175673816
Reviewed by Chris Dumez.
ReadableByteStreamController::closeAndRespondToPendingPullIntos() and
TeeDefaultReadRequest::runCloseSteps() both call close(globalObject) with
the default ShouldThrowOnError::Yes flag and discard the bool return value.
When the first pending pull-into has bytesFilled % elementSize != 0,
close() calls this->error(), then throwException(...), and returns false —
leaving a TypeError pending on the VM with no RETURN_IF_EXCEPTION guard in
any caller.
The sibling BYOB path (TeeBYOBReadRequest::runCloseSteps) was fixed in
rdar://165613840 (303821@main) to use ShouldThrowOnError::No and check the
return; these two callers were not updated at the same time.
This patch mirrors the rdar://165613840 pattern at both unfixed callers:
- Pass ShouldThrowOnError::No and check return value in both callers
- Stop processing pending pull-intos when close() fails
It also makes ShouldThrowOnError parameter non-optional to prevent future
misuse.
Test: streams/byob-close-exception.html
* Source/WebCore/Modules/streams/ReadableByteStreamController.cpp:
(WebCore::ReadableByteStreamController::closeForBindings):
(WebCore::ReadableByteStreamController::closeAndRespondToPendingPullIntos):
* Source/WebCore/Modules/streams/ReadableByteStreamController.h:
* Source/WebCore/Modules/streams/StreamTeeUtilities.cpp:
(WebCore::TeeDefaultReadRequest::runCloseSteps):
Identifier: 305413.819@safari-7624-branch
Identifier: [email protected]
Canonical link: https://commits.webkit.org/305877.875@webkitglib/2.52
Compare: https://github.com/WebKit/WebKit/compare/c3abddf6a1e0...f09ffa51faf4
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
