Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d89c8f0325bb0bf8639e8759ff24f67e646eb70f
https://github.com/WebKit/WebKit/commit/d89c8f0325bb0bf8639e8759ff24f67e646eb70f
Author: Alex Christensen <[email protected]>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
M Source/JavaScriptCore/b3/B3Type.cpp
M Source/JavaScriptCore/jit/OperationResult.h
M Source/JavaScriptCore/runtime/MarkedVector.h
M
Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/include/video_codec_interface.h
M
Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/bounded_inline_vector_impl.h
M Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/buffer.h
M Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h
M Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/zero_memory.h
M Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/fuzz_data_helper.h
M Source/WTF/wtf/IndexMap.h
M Source/WTF/wtf/Vector.h
M Source/WTF/wtf/VectorTraits.h
M Source/WTF/wtf/unicode/icu/ICUHelpers.h
M Source/WebCore/rendering/TextBoxPainter.cpp
Log Message:
-----------
Fix C++26 build
https://bugs.webkit.org/show_bug.cgi?id=318456
rdar://181254230
Reviewed by Abrar Rahman Protyasha.
This PR adapts to a few changes in C++26, making WebKit compile without
warnings or errors.
The changes needed are as follows:
1. std::is_trivial and std::is_trivial_v have been deprecated, and the compiler
suggested I replace
their use with std::is_trivially_copyable_v<T> &&
std::is_trivially_default_constructible_v<T>.
2. Something subtle changed with the std::span constructor with initializer
lists, especially with
std::span<const bool>. A web search pointed me to wg21.link/p4144 though I
can't say I've
followed along closely enough to know if that's the change. In any case, our
Vector::span and
Vector::mutableSpan need explicit std::span<const T>() and std::span<T> now
to continue compiling.
3. std::make_optional with an initializer list and no additional args no longer
compiles as used in
markedTextForTextDecorationLineSpellingError and
markedTextForTextDecorationLineGrammarError.
I did not find the change that caused this to happen, but std::make_optional
without an initializer
list works before and after C++26, so I switch to that.
* Source/JavaScriptCore/b3/B3Type.cpp:
* Source/JavaScriptCore/jit/OperationResult.h:
* Source/JavaScriptCore/runtime/MarkedVector.h:
*
Source/ThirdParty/libwebrtc/Source/webrtc/modules/video_coding/include/video_codec_interface.h:
*
Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/bounded_inline_vector_impl.h:
(webrtc::bounded_inline_vector_impl::=):
* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/buffer.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/logging.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/zero_memory.h:
* Source/ThirdParty/libwebrtc/Source/webrtc/test/fuzzers/fuzz_data_helper.h:
* Source/WTF/wtf/IndexMap.h:
(WTF::IndexMap::resize):
* Source/WTF/wtf/Vector.h:
(WTF::VectorCopier::uninitializedCopy):
* Source/WTF/wtf/VectorTraits.h:
* Source/WTF/wtf/unicode/icu/ICUHelpers.h:
(WTF::CallBufferProducingFunction::argumentTuple):
* Source/WebCore/rendering/TextBoxPainter.cpp:
(WebCore::markedTextForTextDecorationLineSpellingError):
(WebCore::markedTextForTextDecorationLineGrammarError):
Canonical link: https://commits.webkit.org/316420@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
