Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9e267886b98d77c1c8e0247c7db29b9f6b3f81cb
https://github.com/WebKit/WebKit/commit/9e267886b98d77c1c8e0247c7db29b9f6b3f81cb
Author: Antti Koivisto <[email protected]>
Date: 2026-07-03 (Fri, 03 Jul 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-cycles-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-eval-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-invalidation-expected.txt
M Source/WebCore/css/parser/CSSParser.cpp
M Source/WebCore/style/RuleSetBuilder.cpp
M Source/WebCore/style/StyleBuilder.cpp
M Source/WebCore/style/StyleBuilder.h
M Source/WebCore/style/StyleSubstitutionResolver.cpp
Log Message:
-----------
[css-mixins-1] Fix minor @function issues
https://bugs.webkit.org/show_bug.cgi?id=318548
rdar://181322776
Reviewed by Alan Baradlay.
Minor WPT fixes and code cleanups.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-cycles-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/dashed-function-eval-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-invalidation-expected.txt:
* Source/WebCore/css/parser/CSSParser.cpp:
(WebCore::CSSParser::consumeFunctionRule):
Don't validate default value eagerly if it contains substitution functions like
var().
* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::resolveFunctionResult):
Apply function body properties eagerly to detect cycles through unreferenced
local variables.
Remove the unnecessary result value argument.
(WebCore::Style::Builder::resolveCustomPropertyValue):
Allow CSS-wide keywords after substitution on registered properties too.
* Source/WebCore/style/StyleBuilder.h:
* Source/WebCore/style/StyleSubstitutionResolver.cpp:
(WebCore::Style::SubstitutionResolver::substituteDashedFunction):
* Source/WebCore/style/RuleSetBuilder.cpp:
(WebCore::Style::RuleSetBuilder::addMutatingRulesToResolver):
Invalidate the matched declarations cache when registering a function. The
cache keys on
matched properties, not on the function registry, so an unchanged declaration
like width: --f()
would keep a stale value after the function is added or removed. Mirrors
@property registration.
Canonical link: https://commits.webkit.org/316478@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
