Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c973837a1ce5afd395dda139c3c8e4fb5fcdca20
https://github.com/WebKit/WebKit/commit/c973837a1ce5afd395dda139c3c8e4fb5fcdca20
Author: Richard Robinson <[email protected]>
Date: 2026-07-04 (Sat, 04 Jul 2026)
Changed paths:
M Tools/TestWebKitAPI/Helpers/cocoa/AppKit+Extras.swift
M Tools/TestWebKitAPI/Runner/GoogleTestsController.swift
M Tools/TestWebKitAPI/Runner/SwiftTestsController.swift
M Tools/TestWebKitAPI/Runner/TestRunner.swift
M Tools/TestWebKitAPI/Runner/TestWebKitAPI.swift
M Tools/TestWebKitAPI/Runner/TestWebKitAPISupport.h
M Tools/TestWebKitAPI/Runner/TestWebKitAPISupport.mm
M Tools/TestWebKitAPI/Runner/TestsController.cpp
M Tools/TestWebKitAPI/Runner/TestsController.h
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift
M Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/EmbeddedAppKitGesturesTests.swift
Log Message:
-----------
[Swift Testing] Allow tests that require NSApplications to be run in
automation
https://bugs.webkit.org/show_bug.cgi?id=318585
rdar://181352028
Reviewed by Abrar Rahman Protyasha.
Previously, such tests could only be ran manually since TestWebKitAPIBundle
used a real
NSApplication, but TestWebKitAPI didn't. Fix by imbuing the latter with an
NSApplication
and an AppKit event loop to allow these tests to run in EWS.
* Tools/TestWebKitAPI/Helpers/cocoa/AppKit+Extras.swift:
(NSApplication.waitForActivation):
* Tools/TestWebKitAPI/Runner/TestWebKitAPI.swift:
(TestWebKitAPI.run):
(TestWebKitAPI.main):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/BasicAppKitGesturesTests.swift:
(AppKitGesturesTests.singleClickFiresPointerMouseAndClickEvents(_:)):
(AppKitGesturesTests.updatingTextRangeSelectionByUserInteractionUpdatesEditorState(_:)):
(AppKitGesturesTests.draggingSelectionToWindowEdgeAutoscrolls(_:)):
(AppKitGesturesTests.holdingSelectionDragNearEdgeKeepsScrolling):
(AppKitGesturesTests.holdingSelectionDragMidContentDoesNotAutoscroll):
(AppKitGesturesTests.selectionAutoscrollStopsAfterGestureEnds):
(AppKitGesturesTests.draggingSelectionToTopEdgeScrollsUp):
(AppKitGesturesTests.selectionOriginatingNearEdgeWithShortDragDoesNotAutoscroll):
(AppKitGesturesTests.selectionOriginatingNearEdgeAutoscrollsAfterDraggingPastThreshold):
(AppKitGesturesTests.clickingOnSelectedWordOpensContextMenu(_:)):
(AppKitGesturesTests.clickingAndHoldingOnEmptyContentOpensContextMenu(_:)):
(AppKitGesturesTests.longPressOverTextSelectsWordAndDoesNotOpenContextMenu):
(AppKitGesturesTests.scrollingDoesNotRemoveTextSelection):
(AppKitGesturesTests.doubleClickingInWordSelectsWord(_:clickHandler:)):
(AppKitGesturesTests.tripleClickingInPDFSelectsLine):
(AppKitGesturesTests.clickingInWordChangesSelection(_:)):
(AppKitGesturesTests.scrollingChangesScrollPosition(_:)):
(AppKitGesturesTests.interruptingDeceleratingScrollDoesNotFollowLink):
* Tools/TestWebKitAPI/Tests/WebKit/WebPage/AppKit Gesture
Tests/EmbeddedAppKitGesturesTests.swift:
(AppKitGesturesTests.scrollOverNonScrollableWebViewPropagatesToEnclosingScrollView):
(AppKitGesturesTests.pressDragOverTextInWebViewInsideEnclosingScrollViewCreatesSelection):
(AppKitGesturesTests.quickDragOverTextInWebViewInsideEnclosingScrollViewScrolls):
(AppKitGesturesTests.doubleClickingSelectsWordWhenScrolledToTopWithObscuredContentInset):
Canonical link: https://commits.webkit.org/316517@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
