Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9979b0bec00592fa0ce4c217ec9c7326ddf460c9
https://github.com/WebKit/WebKit/commit/9979b0bec00592fa0ce4c217ec9c7326ddf460c9
Author: Ahmad Saleem <[email protected]>
Date: 2026-07-06 (Mon, 06 Jul 2026)
Changed paths:
M Source/WebCore/html/HTMLMediaElement.cpp
Log Message:
-----------
Tautological self-assignment in HTMLMediaElement::setMutedInternal
https://bugs.webkit.org/show_bug.cgi?id=318202
rdar://181005869
Reviewed by Jean-Yves Avenard.
Inside the `if (!m_explicitlyMuted && !implicitlyMuted())` branch, the
assignment `m_explicitlyMuted = !m_explicitlyMuted && !implicitlyMuted();`
re-evaluates a condition that is necessarily true, so it always assigns
true. Replace it with a direct assignment to make the intent clear.
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMutedInternal):
Canonical link: https://commits.webkit.org/316552@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
