Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a8da394bc85e6b94c66f164cb809fa95af4dd6fc
      
https://github.com/WebKit/WebKit/commit/a8da394bc85e6b94c66f164cb809fa95af4dd6fc
  Author: Antti Koivisto <[email protected]>
  Date:   2026-07-06 (Mon, 06 Jul 2026)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-container-dynamic-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-container-style-expected.txt
    M Source/WebCore/animation/BlendingKeyframes.cpp
    M Source/WebCore/css/CSSToLengthConversionData.cpp
    M Source/WebCore/style/MatchedDeclarationsCache.cpp
    M Source/WebCore/style/StyleBuilderState.cpp
    M Source/WebCore/style/StyleBuilderState.h
    M Source/WebCore/style/StyleSubstitutionResolver.cpp
    M Source/WebCore/style/computed/StyleComputedStyle.cpp
    M Source/WebCore/style/computed/StyleComputedStyleBase+ConstructionInlines.h
    M Source/WebCore/style/computed/StyleComputedStyleBase+GettersInlines.h
    M Source/WebCore/style/computed/StyleComputedStyleBase+SettersInlines.h
    M Source/WebCore/style/computed/StyleComputedStyleBase.cpp
    M Source/WebCore/style/computed/StyleComputedStyleBase.h

  Log Message:
  -----------
  [css-mixins-1] Re-resolve functions with @container bodies when the container 
changes
https://bugs.webkit.org/show_bug.cgi?id=318725
rdar://181530290

Reviewed by Alan Baradlay.

Disallow styles generated by container-query-dependent functions from the 
matched declarations cache.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-container-dynamic-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-mixins/function-container-style-expected.txt:
* Source/WebCore/animation/BlendingKeyframes.cpp:
(WebCore::BlendingKeyframes::usesContainerUnits const):
* Source/WebCore/css/CSSToLengthConversionData.cpp:
(WebCore::CSSToLengthConversionData::setUsesContainerUnits const):
* Source/WebCore/style/MatchedDeclarationsCache.cpp:
(WebCore::Style::MatchedDeclarationsCache::isCacheable):
* Source/WebCore/style/StyleBuilderState.cpp:
(WebCore::Style::BuilderState::setIsContainerDependent):
(WebCore::Style::BuilderState::setUsesContainerUnits): Deleted.

Expand the scope of the bit to cover other container dependencies besides 
container units.

* Source/WebCore/style/StyleBuilderState.h:
* Source/WebCore/style/StyleSubstitutionResolver.cpp:
(WebCore::Style::SubstitutionResolver::substituteDashedFunction):

Mark the style container dependent if there is a container query to evaluate 
inside called function.

* Source/WebCore/style/computed/StyleComputedStyle.cpp:
* Source/WebCore/style/computed/StyleComputedStyleBase+ConstructionInlines.h:
(WebCore::Style::ComputedStyleBase::ComputedStyleBase):
(WebCore::Style::ComputedStyleBase::NonInheritedFlags::copyNonInheritedFrom):
* Source/WebCore/style/computed/StyleComputedStyleBase+GettersInlines.h:
(WebCore::Style::ComputedStyleBase::isContainerDependent const):
(WebCore::Style::ComputedStyleBase::usesContainerUnits const): Deleted.
* Source/WebCore/style/computed/StyleComputedStyleBase+SettersInlines.h:
(WebCore::Style::ComputedStyleBase::setIsContainerDependent):
(WebCore::Style::ComputedStyleBase::setUsesContainerUnits): Deleted.
* Source/WebCore/style/computed/StyleComputedStyleBase.cpp:
(WebCore::Style::ComputedStyleBase::NonInheritedFlags::dumpDifferences const):
* Source/WebCore/style/computed/StyleComputedStyleBase.h:

Canonical link: https://commits.webkit.org/316618@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to